[Android] Only reinstall test apk if needed

[Android] Only reinstall test apk if needed

When running tests, we should only be reinstalling the test apk if it
is different than the one currently installed. So, before reinstalling,
query the package manager for the path to the installed apk, and then
only reinstall if the md5sum of the installed apk differs from the one
we are about to install.

NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199835

[klundberg, 2013-05-03 17:31:36]

FYI, I have added Craig as reviewer as Frank is on vacation and won't be back
until the 13th.

[cjhopman, 2013-05-06 16:23:55]

craigdh: ping

[craigdh, 2013-05-06 16:59:56]

https://codereview.chromium.org/14601004/diff/2001/build/android/pylib/androi...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/14601004/diff/2001/build/android/pylib/androi...
build/android/pylib/android_commands.py:675: def CheckMd5Sum(self, local_path,
device_path, ignore_paths=False):
please add a docstring for this function, including the list of args.

https://codereview.chromium.org/14601004/diff/2001/build/android/pylib/gtest/...
File build/android/pylib/gtest/test_package_apk.py (right):

https://codereview.chromium.org/14601004/diff/2001/build/android/pylib/gtest/...
build/android/pylib/gtest/test_package_apk.py:124: installed_apk_path =
pm_path_output[0][8:]
nit: pm_path_output[0].split(':', 1)[1] or h[h.find(':') + 1:] would make what
you're doing more clear than hardcoding 8.

[cjhopman, 2013-05-06 22:32:18]

https://codereview.chromium.org/14601004/diff/2001/build/android/pylib/androi...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/14601004/diff/2001/build/android/pylib/androi...
build/android/pylib/android_commands.py:675: def CheckMd5Sum(self, local_path,
device_path, ignore_paths=False):
On 2013/05/06 16:59:56, craigdh wrote:
> please add a docstring for this function, including the list of args.

Done.

https://codereview.chromium.org/14601004/diff/2001/build/android/pylib/gtest/...
File build/android/pylib/gtest/test_package_apk.py (right):

https://codereview.chromium.org/14601004/diff/2001/build/android/pylib/gtest/...
build/android/pylib/gtest/test_package_apk.py:124: installed_apk_path =
pm_path_output[0][8:]
On 2013/05/06 16:59:56, craigdh wrote:
> nit: pm_path_output[0].split(':', 1)[1] or h[h.find(':') + 1:] would make what
> you're doing more clear than hardcoding 8.

Done.

[craigdh, 2013-05-06 23:44:30]

lgtm.

[cjhopman, 2013-05-13 17:45:34]

nyquist: for COMMITTERS stamp

[nyquist, 2013-05-13 20:18:59]

lgtm

[commit-bot: I haz the power, 2013-05-13 20:26:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cjhopman@chromium.org/14601004/16001

[commit-bot: I haz the power, 2013-05-13 21:18:20]

Retried try job too often on linux_rel for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-05-13 22:23:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cjhopman@chromium.org/14601004/16001

[commit-bot: I haz the power, 2013-05-13 22:23:50]

Change committed as 199835