Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14598011: Convert a BrowserView.BrowserViewLayout interactive_uitest to unit_test (Closed)

Created:
7 years, 7 months ago by James Cook
Modified:
7 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Convert a BrowserView.BrowserViewLayout interactive_uitest to unit_test Instantiate the TemplateURLService dependency of BrowserView in unit_test BrowserViewTest to allow it to happen. BUG=233374 TEST=unit_tests, interactive_ui_tests BrowserView* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198382

Patch Set 1 #

Patch Set 2 : Convert a BrowserView interactive_ui_test to unit_test #

Patch Set 3 : rebase #

Patch Set 4 : rebase again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -106 lines) Patch
M chrome/browser/ui/views/frame/browser_view_interactive_uitest.cc View 1 2 3 chunks +1 line, -103 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view_unittest.cc View 1 5 chunks +141 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
James Cook
Scott, PTAL. This is mostly just moving existing test code from one place to another. ...
7 years, 7 months ago (2013-05-01 23:20:01 UTC) #1
sky
Nice, LGTM
7 years, 7 months ago (2013-05-02 00:36:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/14598011/9001
7 years, 7 months ago (2013-05-02 18:45:13 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) ash_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=109998
7 years, 7 months ago (2013-05-02 21:24:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/14598011/26001
7 years, 7 months ago (2013-05-02 22:58:58 UTC) #5
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) googleurl_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=48701
7 years, 7 months ago (2013-05-02 23:39:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/14598011/26001
7 years, 7 months ago (2013-05-02 23:52:18 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=110175
7 years, 7 months ago (2013-05-03 03:12:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/14598011/26001
7 years, 7 months ago (2013-05-03 03:35:42 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=110367
7 years, 7 months ago (2013-05-03 09:18:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/14598011/26001
7 years, 7 months ago (2013-05-05 18:44:01 UTC) #11
commit-bot: I haz the power
7 years, 7 months ago (2013-05-06 06:16:15 UTC) #12
Message was sent while issue was closed. 
Change committed as 198382

Powered by Google App Engine
This is Rietveld 408576698