chrome/browser/ui/views/frame/browser_view.h - Issue 14589016: Unit test for BrowserViewLayout that does not depend on BrowserView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.h

Issue 14589016: Unit test for BrowserViewLayout that does not depend on BrowserView (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: BrowserViewLayout owns its delegate Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/frame/browser_view.h

diff --git a/chrome/browser/ui/views/frame/browser_view.h b/chrome/browser/ui/views/frame/browser_view.h

index 721f74c68730ebdb734706fe98264054e23a9f8a..6ceb2de5ea37689cbeaae1edfaa7f1aa3a0ff64a 100644

--- a/chrome/browser/ui/views/frame/browser_view.h

+++ b/chrome/browser/ui/views/frame/browser_view.h

@@ -460,7 +460,9 @@ class BrowserView : public BrowserWindow,

views::WebView* GetContentsWebViewForTest() { return contents_web_view_; }

private:

- friend class BrowserViewLayout;

+ // Do not friend BrowserViewLayout. Use the BrowserViewLayoutDelegate

+ // interface to keep these two classes decoupled and testable.

+ friend class BrowserViewLayoutDelegateImpl;

FRIEND_TEST_ALL_PREFIXES(BrowserViewTest, BrowserView);

FRIEND_TEST_ALL_PREFIXES(BrowserViewsAccessibilityTest,

TestAboutChromeViewAccObj);

« no previous file with comments | « no previous file | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »