Issue 14589010: [Replaceable] attributes must be readonly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14589010: [Replaceable] attributes must be readonly (Closed)

Created:
7 years, 7 months ago by haraken

Modified:
7 years, 7 months ago

Reviewers:
eseidel1, abarth-chromium

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

[Replaceable] attributes must be readonly Web IDL spec: http://dev.w3.org/2006/webapi/WebIDL/#Replaceable This change doesn't affect generated code, because the code generator already assumes that [Replaceable] attributes are readonly. R=abarth,eseidel Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149756

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Source/core/html/HTMLDocument.idl	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/core/page/DOMWindow.idl	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

abarth-chromium

LGTM Can we make the code generator fail if readonly is missing?

7 years, 7 months ago (2013-05-06 17:22:22 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/14589010/1

7 years, 7 months ago (2013-05-06 17:22:39 UTC) #3

Message was sent while issue was closed.

Change committed as 149756