chrome/browser/resources/file_manager/js/default_action_dialog.js - Issue 14589007: Files.app: Fixed the icon of image open item in default action dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/file_manager/js/default_action_dialog.js

Issue 14589007: Files.app: Fixed the icon of image open item in default action dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/file_manager/js/default_action_dialog.js

diff --git a/chrome/browser/resources/file_manager/js/default_action_dialog.js b/chrome/browser/resources/file_manager/js/default_action_dialog.js

index f84a6ea1dfb4ce550888b31593d27c9ed7c1485c..55ed02eb440040323989f61ca7dcb525f37222b2 100644

--- a/chrome/browser/resources/file_manager/js/default_action_dialog.js

+++ b/chrome/browser/resources/file_manager/js/default_action_dialog.js

@@ -69,11 +69,11 @@ cr.define('cr.filebrowser', function() {

var div = this.document_.createElement('div');

div.textContent = item.label;

- if (item.iconType)

+ if (item.iconType) {

div.setAttribute('file-type-icon', item.iconType);

- if (item.iconUrl)

+ } else if (item.iconUrl) {

div.style.backgroundImage = 'url(' + item.iconUrl + ')';

+ }

if (item.class)

div.classList.add(item.class);

« no previous file with comments | « no previous file | no next file » | no next file with comments »