Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Unified Diff: chrome/browser/extensions/api/storage/storage_schema_manifest_handler.cc

Issue 14587009: Added a PolicyManifestHandler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: actually upload changes Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/storage/storage_schema_manifest_handler.cc
diff --git a/chrome/browser/extensions/api/storage/storage_schema_manifest_handler.cc b/chrome/browser/extensions/api/storage/storage_schema_manifest_handler.cc
new file mode 100644
index 0000000000000000000000000000000000000000..31174fd3c594c7926e0ba6080cbf17fd54e70aba
--- /dev/null
+++ b/chrome/browser/extensions/api/storage/storage_schema_manifest_handler.cc
@@ -0,0 +1,83 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/api/storage/storage_schema_manifest_handler.h"
+
+#include "base/file_util.h"
+#include "base/files/file_path.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/string16.h"
+#include "base/stringprintf.h"
+#include "base/utf_string_conversions.h"
+#include "chrome/browser/policy/policy_schema.h"
+#include "chrome/common/extensions/extension.h"
+#include "chrome/common/extensions/extension_manifest_constants.h"
+#include "chrome/common/extensions/manifest.h"
+#include "chrome/common/extensions/permissions/api_permission.h"
+
+namespace extensions {
+
+namespace {
+
+const char kMissingPermission[] =
+ "The storage permission is required to use storage.managed_schema";
+const char kInvalidValue[] =
+ "Invalid value for storage.managed_schema - must be a string";
+const char kInvalidPath[] =
+ "storage.managed_schema must be a relative path without ..";
+
+} // namespace
+
+StorageSchemaManifestHandler::StorageSchemaManifestHandler() {}
+
+StorageSchemaManifestHandler::~StorageSchemaManifestHandler() {}
+
+bool StorageSchemaManifestHandler::Parse(Extension* extension,
+ string16* error) {
+ std::string path;
bartfab (slow) 2013/05/22 11:00:09 Nit: #include <string>
Joao da Silva 2013/05/22 12:26:20 Done.
+ if (!extension->manifest()->GetString(
+ extension_manifest_keys::kStorageManagedSchema, &path)) {
+ *error = ASCIIToUTF16(kInvalidValue);
+ return false;
+ }
+ return true;
+}
+
+bool StorageSchemaManifestHandler::Validate(
+ const Extension* extension,
+ std::string* error,
+ std::vector<InstallWarning>* warnings) const {
bartfab (slow) 2013/05/22 11:00:09 Nit 1: #include <vector> Nit 2: #include "chrome/c
Joao da Silva 2013/05/22 12:26:20 Done.
+ if (!extension->HasAPIPermission(APIPermission::kStorage)) {
+ *error = kMissingPermission;
+ return false;
+ }
+ std::string path;
+ extension->manifest()->GetString(
+ extension_manifest_keys::kStorageManagedSchema, &path);
+ base::FilePath file = base::FilePath::FromUTF8Unsafe(path);
+ if (file.IsAbsolute() || file.ReferencesParent()) {
+ *error = kInvalidPath;
+ return false;
+ }
+ file = extension->path().AppendASCII(path);
+ if (!file_util::PathExists(file)) {
+ *error =
+ base::StringPrintf("File does not exist: %s", file.value().c_str());
+ return false;
+ }
+ std::string content;
+ if (!file_util::ReadFileToString(file, &content)) {
+ *error = base::StringPrintf("Can't read %s", file.value().c_str());
+ return false;
+ }
+ scoped_ptr<policy::PolicySchema> schema =
+ policy::PolicySchema::Parse(content, error);
+ return !!schema;
+}
+
+const std::vector<std::string> StorageSchemaManifestHandler::Keys() const {
+ return SingleKey(extension_manifest_keys::kStorageManagedSchema);
+}
+
+} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698