Issue 14585006: chromite_wrapper: Support git submodule checkouts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14585006: chromite_wrapper: Support git submodule checkouts. (Closed)

Created:
7 years, 7 months ago by rcui1

Modified:
7 years, 7 months ago

Reviewers:
cmp, davidjames, cmp_google, M-A Ruel, szager1

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

chromite_wrapper: Support git submodule checkouts. BUG=None TEST=Ran locally Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=198184

Patch Set 1 #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	support/chromite_wrapper	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rcui@google.com/14585006/1

7 years, 7 months ago (2013-05-03 21:13:55 UTC) #5

cmp_google

7 years, 7 months ago (2013-05-03 21:45:51 UTC) #7

Message was sent while issue was closed.

lgtm with nit

+szager

https://chromiumcodereview.appspot.com/14585006/diff/1/support/chromite_wrapper
File support/chromite_wrapper (right):

https://chromiumcodereview.appspot.com/14585006/diff/1/support/chromite_wrapp...
support/chromite_wrapper:33: """Find the chromite dir in a repo or gclient
checkout."""
Update the heredoc so it's correct.

Expand Messages | Collapse Messages