Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14584004: Remove ash-disable-launcher-per-display flag (Closed)

Created:
7 years, 7 months ago by oshima
Modified:
7 years, 7 months ago
Reviewers:
James Cook
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove ash-disable-launcher-per-display flag BUG=239681 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199368

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -161 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M ash/ash_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/ash_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/display/display_controller_unittest.cc View 3 chunks +2 lines, -12 lines 0 comments Download
M ash/launcher/launcher_view.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/root_window_controller.cc View 3 chunks +11 lines, -18 lines 0 comments Download
M ash/root_window_controller_unittest.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M ash/screen_ash_unittest.cc View 2 chunks +6 lines, -18 lines 0 comments Download
M ash/shelf/shelf_widget_unittest.cc View 1 chunk +17 lines, -19 lines 0 comments Download
M ash/shell.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/shell.cc View 3 chunks +9 lines, -24 lines 0 comments Download
M ash/wm/ash_activation_controller.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc View 3 chunks +4 lines, -15 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc View 3 chunks +3 lines, -15 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
oshima
7 years, 7 months ago (2013-05-09 11:39:24 UTC) #1
James Cook
LGTM Could you create a tracking bug for this before landing it? It changes enough ...
7 years, 7 months ago (2013-05-09 17:17:30 UTC) #2
oshima
done
7 years, 7 months ago (2013-05-10 00:20:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/14584004/2001
7 years, 7 months ago (2013-05-10 00:21:27 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 7 months ago (2013-05-10 00:39:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/14584004/2001
7 years, 7 months ago (2013-05-10 00:50:54 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 7 months ago (2013-05-10 00:58:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/14584004/2001
7 years, 7 months ago (2013-05-10 01:19:39 UTC) #8
commit-bot: I haz the power
7 years, 7 months ago (2013-05-10 04:33:40 UTC) #9
Message was sent while issue was closed. 
Change committed as 199368

Powered by Google App Engine
This is Rietveld 408576698