Do not coalesce X touch move events in aura.

Do not coalesce X touch move events in aura.

BUG=218270
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200636

[DaveMoore, 2013-05-15 21:59:03]

https://codereview.chromium.org/14582028/diff/1/ui/base/x/x11_util.cc
File ui/base/x/x11_util.cc (right):

https://codereview.chromium.org/14582028/diff/1/ui/base/x/x11_util.cc#newcode616
ui/base/x/x11_util.cc:616:
UMA_HISTOGRAM_COUNTS_10000("Event.CoalescedCount.Mouse", num_coalesed);
Nit: fix spelling

[varunjain, 2013-05-15 22:09:37]

https://codereview.chromium.org/14582028/diff/1/ui/base/x/x11_util.cc
File ui/base/x/x11_util.cc (right):

https://codereview.chromium.org/14582028/diff/1/ui/base/x/x11_util.cc#newcode616
ui/base/x/x11_util.cc:616:
UMA_HISTOGRAM_COUNTS_10000("Event.CoalescedCount.Mouse", num_coalesed);
On 2013/05/15 21:59:03, DaveMoore wrote:
> Nit: fix spelling

Done.

[sky, 2013-05-16 14:43:19]

LGTM

[commit-bot: I haz the power, 2013-05-16 14:44:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varunjain@chromium.org/14582028/6001

[commit-bot: I haz the power, 2013-05-16 15:24:47]

Retried try job too often on linux_chromeos for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-05-16 17:34:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varunjain@chromium.org/14582028/6001

[commit-bot: I haz the power, 2013-05-16 22:04:26]

Change committed as 200636

[dshwang, 2013-11-22 19:51:52]

On 2013/05/16 22:04:26, I haz the power (commit-bot) wrote:
> Change committed as 200636

Hi, may I ask why do not coalesce X touch move events in aura?
Thank you in advance.

[dshwang, 2013-11-22 19:53:45]

On 2013/11/22 19:51:52, dshwang wrote:
> On 2013/05/16 22:04:26, I haz the power (commit-bot) wrote:
> > Change committed as 200636
> 
> Hi, may I ask why do not coalesce X touch move events in aura?
> Thank you in advance.

Currently, we still coalesce X mouse events in aura.
void RootWindowHostX11::DispatchXI2Event(const base::NativeEvent& event) {
  ...
      if (type == ui::ET_MOUSE_MOVED || type == ui::ET_MOUSE_DRAGGED) {
        // If this is a motion event, we want to coalesce all pending motion
        // events that are at the top of the queue.
        num_coalesced = ui::CoalescePendingMotionEvents(xev, &last_event);
        if (num_coalesced > 0)
          xev = &last_event;

[sadrul, 2013-11-22 20:36:10]

On 2013/11/22 19:53:45, dshwang wrote:
> On 2013/11/22 19:51:52, dshwang wrote:
> > On 2013/05/16 22:04:26, I haz the power (commit-bot) wrote:
> > > Change committed as 200636
> > 
> > Hi, may I ask why do not coalesce X touch move events in aura?
> > Thank you in advance.

I don't remember clearly. I think the coalescing code didn't work correctly for
events coming from floating-slave devices?

> 
> Currently, we still coalesce X mouse events in aura.
> void RootWindowHostX11::DispatchXI2Event(const base::NativeEvent& event) {
>   ...
>       if (type == ui::ET_MOUSE_MOVED || type == ui::ET_MOUSE_DRAGGED) {
>         // If this is a motion event, we want to coalesce all pending motion
>         // events that are at the top of the queue.
>         num_coalesced = ui::CoalescePendingMotionEvents(xev, &last_event);
>         if (num_coalesced > 0)
>           xev = &last_event;