Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(926)

Issue 14582021: Only enable malware IP matching feature for canary and dev channel. (Closed)

Created:
7 years, 7 months ago by kewang
Modified:
7 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Only enable malware IP matching feature for canary and dev channel. BUG=176647 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203099

Patch Set 1 #

Patch Set 2 : Fix the unittest #

Patch Set 3 : Code merge #

Patch Set 4 : Add back the unittest #

Patch Set 5 : git pull patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -9 lines) Patch
M chrome/browser/safe_browsing/client_side_detection_host.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host.cc View 1 2 4 chunks +21 lines, -9 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host_unittest.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
kewang
Is there any thread requirement for the chrome version check?
7 years, 7 months ago (2013-05-10 09:27:25 UTC) #1
noé
lgtm
7 years, 7 months ago (2013-05-10 17:09:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kewang@google.com/14582021/21001
7 years, 7 months ago (2013-05-27 02:55:16 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=5074
7 years, 7 months ago (2013-05-27 03:02:34 UTC) #4
kewang
Seems Noe's lgtm does not work here. When I tried commit, error msg as: Missing ...
7 years, 7 months ago (2013-05-27 03:08:03 UTC) #5
Brian Ryner
fyi I think the issue is that Noe LGTMd from his chromium.org account, but the ...
7 years, 6 months ago (2013-05-28 18:57:20 UTC) #6
Brian Ryner
lgtm
7 years, 6 months ago (2013-05-28 19:00:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kewang@google.com/14582021/30001
7 years, 6 months ago (2013-05-30 02:15:35 UTC) #8
commit-bot: I haz the power
7 years, 6 months ago (2013-05-30 06:40:37 UTC) #9
Message was sent while issue was closed.
Change committed as 203099

Powered by Google App Engine
This is Rietveld 408576698