Source/core/dom/SelectorQuery.h - Issue 14581013: Optimized querySelector(All) when selector contains #id.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/SelectorQuery.h

Issue 14581013: Optimized querySelector(All) when selector contains #id. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed review issues in Patch Set 2 Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/SelectorQuery.h

diff --git a/Source/core/dom/SelectorQuery.h b/Source/core/dom/SelectorQuery.h

index 779e782cf46b895e8136e3372037f6b05f972e24..79e6381faeea9d295ebf021105778e29235551c4 100644

--- a/Source/core/dom/SelectorQuery.h

+++ b/Source/core/dom/SelectorQuery.h

@@ -56,7 +56,7 @@ private:

};

bool selectorMatches(const SelectorData&, Element*, const Node*) const;

- bool canUseIdLookup(Node* rootNode) const;

+ std::pair<bool, Node*> findTraverseRoot(Node* traverseRoot) const;

template <bool firstMatchOnly>

void execute(Node* rootNode, Vector<RefPtr<Node> >&) const;

« no previous file with comments | « PerformanceTests/Parser/query-selector-id-last.html ('k') | Source/core/dom/SelectorQuery.cpp » ('j') | no next file with comments »