Files.app: Bring back the offline feature.

Files.app: Bring back the offline feature.

This CL added the 'offline' directory to the directory tree and the test for offline feature.

BUG=238545
TEST=Open the file browser, ensure that the offline feature works

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202383

[hirono, 2013-05-09 06:25:24]

I'd like to bring back the offline feature.
Could you check this CL?

Thank you very much.

[satorux1, 2013-05-09 07:10:42]

Let's bring it back once the feature is re-implemented.

[hirono, 2013-05-24 01:06:49]

On 2013/05/09 07:10:42, satorux1 wrote:
> Let's bring it back once the feature is re-implemented.

@satorux1 - It is time to bring back the offline feature!

[hirono, 2013-05-24 10:03:18]

On 2013/05/24 01:06:49, hirono wrote:
> On 2013/05/09 07:10:42, satorux1 wrote:
> > Let's bring it back once the feature is re-implemented.
> 
> @satorux1 - It is time to bring back the offline feature!

@satorux1, @yoshiki - Now the offline feature have been re-implemented.
Could you start to review this patch?
Thank you.

[satorux1, 2013-05-24 10:04:28]

LGTM. Please also get this reviewed by yoshiki

[yoshiki, 2013-05-24 14:39:48]

lgtm with nit

https://codereview.chromium.org/14577013/diff/5001/chrome/browser/resources/f...
File chrome/browser/resources/file_manager/js/directory_model.js (right):

https://codereview.chromium.org/14577013/diff/5001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/directory_model.js:116:
DirectoryModel.FAKE_DRIVE_SPECIAL_SEARCH_ENTRIES =
nit: It's not your fault, but could you change the format to match the coding
style?
http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone...
===
DirectoryModel.FAKE_DRIVE_SPECIAL_SEARCH_ENTRIES = [
  DirectoryModel.fakeDriveSharedWithMeEntry_,
  ...,
  ...
];
===

[hirono, 2013-05-27 01:07:47]

Fixed.
Thank you!

https://codereview.chromium.org/14577013/diff/5001/chrome/browser/resources/f...
File chrome/browser/resources/file_manager/js/directory_model.js (right):

https://codereview.chromium.org/14577013/diff/5001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/directory_model.js:116:
DirectoryModel.FAKE_DRIVE_SPECIAL_SEARCH_ENTRIES =
On 2013/05/24 14:39:48, yoshiki wrote:
> nit: It's not your fault, but could you change the format to match the coding
> style?
>
http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone...
> ===
> DirectoryModel.FAKE_DRIVE_SPECIAL_SEARCH_ENTRIES = [
>   DirectoryModel.fakeDriveSharedWithMeEntry_,
>   ...,
>   ...
> ];
> ===

Done.

[commit-bot: I haz the power, 2013-05-27 01:08:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hirono@chromium.org/14577013/18001

[commit-bot: I haz the power, 2013-05-27 01:08:04]

Failed to apply patch for
chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc
  Hunk #1 FAILED at 816.
  Hunk #2 FAILED at 888.
  2 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc.rej

Patch:      
chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc
Index:
chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc
diff --git
a/chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc
b/chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc
index
2ec3f4000839bb7c31d53b38958725a95fdd9031..ebee4372bbdeb221e41a84495cec5bcc12ac21d5
100644
---
a/chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc
+++
b/chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc
@@ -816,8 +816,7 @@ IN_PROC_BROWSER_TEST_P(FileManagerBrowserDriveTest,
TestOpenRecent) {
   ASSERT_TRUE(catcher.GetNextResult()) << catcher.message();
 }
 
-// TODO(hirono): Bring back the offline feature. http://crbug.com/238545
-IN_PROC_BROWSER_TEST_P(FileManagerBrowserDriveTest, DISABLED_TestOpenOffline) {
+IN_PROC_BROWSER_TEST_P(FileManagerBrowserDriveTest, TestOpenOffline) {
   ASSERT_NO_FATAL_FAILURE(PrepareVolume());
   ResultCatcher catcher;
   ASSERT_NO_FATAL_FAILURE(StartTest("openSidebarOffline"));
@@ -888,18 +887,16 @@ IN_PROC_BROWSER_TEST_P(FileManagerBrowserTransferTest,
   ASSERT_TRUE(catcher.GetNextResult()) << catcher.message();
 }
 
-// TODO(hirono): Bring back the offline feature. http://crbug.com/238545
 IN_PROC_BROWSER_TEST_P(FileManagerBrowserTransferTest,
-                       DISABLED_TransferFromOfflineToDownloads) {
+                       TransferFromOfflineToDownloads) {
   ASSERT_NO_FATAL_FAILURE(PrepareVolume());
   ResultCatcher catcher;
   ASSERT_NO_FATAL_FAILURE(StartTest("transferFromOfflineToDownloads"));
   ASSERT_TRUE(catcher.GetNextResult()) << catcher.message();
 }
 
-// TODO(hirono): Bring back the offline feature. http://crbug.com/238545
 IN_PROC_BROWSER_TEST_P(FileManagerBrowserTransferTest,
-                       DISABLED_TransferFromOfflineToDrive) {
+                       TransferFromOfflineToDrive) {
   ASSERT_NO_FATAL_FAILURE(PrepareVolume());
   ResultCatcher catcher;
   ASSERT_NO_FATAL_FAILURE(StartTest("transferFromOfflineToDrive"));

[commit-bot: I haz the power, 2013-05-27 01:40:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hirono@chromium.org/14577013/29001

[commit-bot: I haz the power, 2013-05-27 04:49:01]

Retried try job too often on win_rel for step(s) sync_integration_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-05-27 05:01:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hirono@chromium.org/14577013/29001

[commit-bot: I haz the power, 2013-05-27 08:26:28]

Change committed as 202383