Issue 14576007: pp::FileSystem: add copy constrctor

Issue 14576007: pp::FileSystem: add copy constrctor (Closed)

Created:
7 years, 7 months ago by victorhsieh

Modified:
7 years, 7 months ago

Reviewers:
yzshen1

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

pp::FileSystem: add copy constrctor This will make the output callback of ExtCrxFileSystemPrivate.Open easier to use. BUG=223301 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199121

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
M	ppapi/cpp/file_io.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/cpp/file_system.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	ppapi/cpp/file_system.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

yzshen1

LGTM https://codereview.chromium.org/14576007/diff/2001/ppapi/cpp/file_system.h File ppapi/cpp/file_system.h (right): https://codereview.chromium.org/14576007/diff/2001/ppapi/cpp/file_system.h#newcode33 ppapi/cpp/file_system.h:33: /// @param[in] other A pointer to a <code>FileSystem</code>. ...

7 years, 7 months ago (2013-05-08 23:25:42 UTC) #2

victorhsieh

https://codereview.chromium.org/14576007/diff/2001/ppapi/cpp/file_system.h File ppapi/cpp/file_system.h (right): https://codereview.chromium.org/14576007/diff/2001/ppapi/cpp/file_system.h#newcode33 ppapi/cpp/file_system.h:33: /// @param[in] other A pointer to a <code>FileSystem</code>. On ...

7 years, 7 months ago (2013-05-08 23:35:53 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/victorhsieh@chromium.org/14576007/7001

7 years, 7 months ago (2013-05-08 23:36:01 UTC) #4

Message was sent while issue was closed.

Change committed as 199121

Expand Messages | Collapse Messages