Use correctly mirrored points for ideal bounds of launcher item icons.

Use correctly mirrored points for ideal bounds of launcher item icons.

BUG=234264
TEST=LauncherViewTest.IdealBoundsOfItemIcon, LauncherViewRTLTest.IdealBoundsOfItemIcon, PanelLayoutManagerRTLTest.AddOnePanel, PanelWindowResizerRTLTest.DragReordersPanelsHorizontal
TEST=Set language to an RTL language. Open a panel. Panel should appear aligned over panel icon.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203895

[flackr, 2013-05-02 20:30:43]

Please take a look, thanks! I've tested left and right aligned launchers as well
and other than them being broken for other reasons, the panel position is
correct :-).

Also note, that this only positions the panel correctly over the icon, the icon
is still on top of the tray due to http://crbug.com/234271

[stevenjb, 2013-05-02 21:33:26]

lgtm

[flackr, 2013-05-03 17:21:48]

+sky, PTAL, thanks.

[varkha, 2013-05-03 17:48:14]

https://codereview.chromium.org/14574009/diff/2001/ash/wm/panels/panel_layout...
File ash/wm/panels/panel_layout_manager_unittest.cc (right):

https://codereview.chromium.org/14574009/diff/2001/ash/wm/panels/panel_layout...
ash/wm/panels/panel_layout_manager_unittest.cc:286: 
RTL could be a test parameter set up with INSTANTIATE_TEST_CASE_P. Then all the
tests would run twice - with and without RTL.

https://codereview.chromium.org/14574009/diff/2001/ash/wm/panels/panel_window...
File ash/wm/panels/panel_window_resizer_unittest.cc (right):

https://codereview.chromium.org/14574009/diff/2001/ash/wm/panels/panel_window...
ash/wm/panels/panel_window_resizer_unittest.cc:210: 
RTL could be a test parameter set up with INSTANTIATE_TEST_CASE_P. Then all the
tests would run twice - with and without RTL. You can then tune which tests we
want to run with RTL and which not. I think this will improve the coverage.

[flackr, 2013-05-17 20:31:14]

https://codereview.chromium.org/14574009/diff/2001/ash/wm/panels/panel_layout...
File ash/wm/panels/panel_layout_manager_unittest.cc (right):

https://codereview.chromium.org/14574009/diff/2001/ash/wm/panels/panel_layout...
ash/wm/panels/panel_layout_manager_unittest.cc:286: 
On 2013/05/03 17:48:14, varkha wrote:
> RTL could be a test parameter set up with INSTANTIATE_TEST_CASE_P. Then all
the
> tests would run twice - with and without RTL.

This would be nice, however as far as I can tell it would require reimplementing
AshTestBase. AshTestBase extends testing::Test, but in order to use
INSTANTIATE_TEST_CASE_P you have to extend testing::TestWithParam<T> where T is
the type of the test parameter.

[varkha, 2013-05-17 20:44:27]

is multiple inheritance a problem as in DetachToBrowserTabDragControllerTest?

[flackr, 2013-05-17 20:46:25]

On 2013/05/17 20:44:27, varkha wrote:
> is multiple inheritance a problem as in DetachToBrowserTabDragControllerTest?

Yes, having multiple inheritance of testing::Test causes problems. I did try
this :-).

[flackr, 2013-05-17 21:06:08]

On 2013/05/17 20:46:25, flackr wrote:
> On 2013/05/17 20:44:27, varkha wrote:
> > is multiple inheritance a problem as in
DetachToBrowserTabDragControllerTest?
> 
> Yes, having multiple inheritance of testing::Test causes problems. I did try
> this :-).

Ah yes, WithParamInterface doesn't extend Test, so this should work. I'll look
into this.

[flackr, 2013-06-03 17:08:10]

Done. PTAL, thanks.

[sky, 2013-06-03 17:50:15]

LGTM

[commit-bot: I haz the power, 2013-06-03 18:16:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/flackr@chromium.org/14574009/36001

[commit-bot: I haz the power, 2013-06-04 07:25:49]

Change committed as 203895