Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 14569002: Remove getpid from SuperMox. (Closed)

Created:
7 years, 7 months ago by M-A Ruel
Modified:
7 years, 7 months ago
Reviewers:
iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org
Visibility:
Public.

Description

Remove getpid from SuperMox. It is called by logging.foo() so it breaks this use case. TBR=iannucci@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=197190

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M testing_support/super_mox.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
My specific use case is the unit test for build/scripts/slave/get_swarm_results.py and I'm starting to use ...
7 years, 7 months ago (2013-04-30 00:41:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/14569002/1
7 years, 7 months ago (2013-04-30 00:41:31 UTC) #2
commit-bot: I haz the power
Change committed as 197190
7 years, 7 months ago (2013-04-30 00:42:59 UTC) #3
iannucci
7 years, 7 months ago (2013-04-30 00:48:59 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698