Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 14566007: Overwrite the handler using Set. (Closed)

Created:
7 years, 7 months ago by Toon Verwaest
Modified:
7 years, 7 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Overwrite the handler using Set. InsertAt apparently inserts by moving the other elements... that does not work. Committed: https://code.google.com/p/v8/source/detail?r=14535

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M src/ic.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/list.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/list-inl.h View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 7 months ago (2013-05-03 01:00:03 UTC) #1
danno
lgtm
7 years, 7 months ago (2013-05-03 08:47:31 UTC) #2
Toon Verwaest
7 years, 7 months ago (2013-05-03 08:49:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14535 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698