Issue 14564007: Remove mozc from whitelist.

Issue 14564007: Remove mozc from whitelist. (Closed)

Created:
7 years, 7 months ago by Seigo Nonaka

Modified:
7 years, 7 months ago

Reviewers:
Zachary Kuznia

CC:
chromium-reviews, nona+watch_chromium.org, stevenjb+watch_chromium.org, yusukes+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove mozc from whitelist. BUG=236747 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198379

Patch Set 1 #

Patch Set 2 : TestUpdate #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -87 lines)			Patch
M	chrome/browser/chromeos/input_method/input_method_manager_impl.cc	View	1	2 chunks	+7 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc	View	1	15 chunks	+40 lines, -27 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util_unittest.cc	View	1	8 chunks	+21 lines, -53 lines	0 comments	Download
M	chromeos/ime/input_method_whitelist_unittest.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chromeos/ime/input_methods.txt	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/14564007/1

7 years, 7 months ago (2013-05-02 07:25:17 UTC) #4

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=109633

7 years, 7 months ago (2013-05-02 08:16:02 UTC) #5

Seigo Nonaka

Ugh, seems some tests depends whitelisted input methods. I'm going to change all "mozc" to ...

7 years, 7 months ago (2013-05-02 10:05:46 UTC) #6

Seigo Nonaka

Zach, please take another look? I updated all hard-coded "mozc"/"mozc-jp"/"mozc-dv" to nacl based one. I ...

7 years, 7 months ago (2013-05-02 12:30:29 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/14564007/15002

7 years, 7 months ago (2013-05-05 14:57:29 UTC) #9

Message was sent while issue was closed.

Change committed as 198379

Expand Messages | Collapse Messages