Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: src/x64/lithium-codegen-x64.cc

Issue 14556007: Always tag number candidate as smi if it does not come from load-keyed. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/lithium-codegen-mips.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4785 matching lines...) Expand 10 before | Expand all | Expand 10 after
4796 HLoadKeyed* load = HLoadKeyed::cast(value); 4796 HLoadKeyed* load = HLoadKeyed::cast(value);
4797 if (load->UsesMustHandleHole()) { 4797 if (load->UsesMustHandleHole()) {
4798 if (load->hole_mode() == ALLOW_RETURN_HOLE) { 4798 if (load->hole_mode() == ALLOW_RETURN_HOLE) {
4799 mode = NUMBER_CANDIDATE_IS_SMI_CONVERT_HOLE; 4799 mode = NUMBER_CANDIDATE_IS_SMI_CONVERT_HOLE;
4800 } else { 4800 } else {
4801 mode = NUMBER_CANDIDATE_IS_SMI_OR_HOLE; 4801 mode = NUMBER_CANDIDATE_IS_SMI_OR_HOLE;
4802 } 4802 }
4803 } else { 4803 } else {
4804 mode = NUMBER_CANDIDATE_IS_SMI; 4804 mode = NUMBER_CANDIDATE_IS_SMI;
4805 } 4805 }
4806 } else {
4807 mode = NUMBER_CANDIDATE_IS_SMI;
4806 } 4808 }
4807 } 4809 }
4808 4810
4809 EmitNumberUntagD(input_reg, result_reg, 4811 EmitNumberUntagD(input_reg, result_reg,
4810 instr->hydrogen()->deoptimize_on_undefined(), 4812 instr->hydrogen()->deoptimize_on_undefined(),
4811 instr->hydrogen()->deoptimize_on_minus_zero(), 4813 instr->hydrogen()->deoptimize_on_minus_zero(),
4812 instr->environment(), 4814 instr->environment(),
4813 mode); 4815 mode);
4814 } 4816 }
4815 4817
(...skipping 914 matching lines...) Expand 10 before | Expand all | Expand 10 after
5730 FixedArray::kHeaderSize - kPointerSize)); 5732 FixedArray::kHeaderSize - kPointerSize));
5731 __ bind(&done); 5733 __ bind(&done);
5732 } 5734 }
5733 5735
5734 5736
5735 #undef __ 5737 #undef __
5736 5738
5737 } } // namespace v8::internal 5739 } } // namespace v8::internal
5738 5740
5739 #endif // V8_TARGET_ARCH_X64 5741 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/mips/lithium-codegen-mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698