Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Side by Side Diff: src/mips/lithium-codegen-mips.cc

Issue 14556007: Always tag number candidate as smi if it does not come from load-keyed. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4837 matching lines...) Expand 10 before | Expand all | Expand 10 after
4848 HLoadKeyed* load = HLoadKeyed::cast(value); 4848 HLoadKeyed* load = HLoadKeyed::cast(value);
4849 if (load->UsesMustHandleHole()) { 4849 if (load->UsesMustHandleHole()) {
4850 if (load->hole_mode() == ALLOW_RETURN_HOLE) { 4850 if (load->hole_mode() == ALLOW_RETURN_HOLE) {
4851 mode = NUMBER_CANDIDATE_IS_SMI_CONVERT_HOLE; 4851 mode = NUMBER_CANDIDATE_IS_SMI_CONVERT_HOLE;
4852 } else { 4852 } else {
4853 mode = NUMBER_CANDIDATE_IS_SMI_OR_HOLE; 4853 mode = NUMBER_CANDIDATE_IS_SMI_OR_HOLE;
4854 } 4854 }
4855 } else { 4855 } else {
4856 mode = NUMBER_CANDIDATE_IS_SMI; 4856 mode = NUMBER_CANDIDATE_IS_SMI;
4857 } 4857 }
4858 } else {
4859 mode = NUMBER_CANDIDATE_IS_SMI;
4858 } 4860 }
4859 } 4861 }
4860 4862
4861 EmitNumberUntagD(input_reg, result_reg, 4863 EmitNumberUntagD(input_reg, result_reg,
4862 instr->hydrogen()->deoptimize_on_undefined(), 4864 instr->hydrogen()->deoptimize_on_undefined(),
4863 instr->hydrogen()->deoptimize_on_minus_zero(), 4865 instr->hydrogen()->deoptimize_on_minus_zero(),
4864 instr->environment(), 4866 instr->environment(),
4865 mode); 4867 mode);
4866 } 4868 }
4867 4869
(...skipping 917 matching lines...) Expand 10 before | Expand all | Expand 10 after
5785 __ Subu(scratch, result, scratch); 5787 __ Subu(scratch, result, scratch);
5786 __ lw(result, FieldMemOperand(scratch, 5788 __ lw(result, FieldMemOperand(scratch,
5787 FixedArray::kHeaderSize - kPointerSize)); 5789 FixedArray::kHeaderSize - kPointerSize));
5788 __ bind(&done); 5790 __ bind(&done);
5789 } 5791 }
5790 5792
5791 5793
5792 #undef __ 5794 #undef __
5793 5795
5794 } } // namespace v8::internal 5796 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698