Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 14556007: Always tag number candidate as smi if it does not come from load-keyed. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5492 matching lines...) Expand 10 before | Expand all | Expand 10 after
5503 HLoadKeyed* load = HLoadKeyed::cast(value); 5503 HLoadKeyed* load = HLoadKeyed::cast(value);
5504 if (load->UsesMustHandleHole()) { 5504 if (load->UsesMustHandleHole()) {
5505 if (load->hole_mode() == ALLOW_RETURN_HOLE) { 5505 if (load->hole_mode() == ALLOW_RETURN_HOLE) {
5506 mode = NUMBER_CANDIDATE_IS_SMI_CONVERT_HOLE; 5506 mode = NUMBER_CANDIDATE_IS_SMI_CONVERT_HOLE;
5507 } else { 5507 } else {
5508 mode = NUMBER_CANDIDATE_IS_SMI_OR_HOLE; 5508 mode = NUMBER_CANDIDATE_IS_SMI_OR_HOLE;
5509 } 5509 }
5510 } else { 5510 } else {
5511 mode = NUMBER_CANDIDATE_IS_SMI; 5511 mode = NUMBER_CANDIDATE_IS_SMI;
5512 } 5512 }
5513 } else {
5514 mode = NUMBER_CANDIDATE_IS_SMI;
5513 } 5515 }
5514 } 5516 }
5515 5517
5516 if (CpuFeatures::IsSupported(SSE2)) { 5518 if (CpuFeatures::IsSupported(SSE2)) {
5517 CpuFeatureScope scope(masm(), SSE2); 5519 CpuFeatureScope scope(masm(), SSE2);
5518 XMMRegister result_reg = ToDoubleRegister(result); 5520 XMMRegister result_reg = ToDoubleRegister(result);
5519 EmitNumberUntagD(input_reg, 5521 EmitNumberUntagD(input_reg,
5520 temp_reg, 5522 temp_reg,
5521 result_reg, 5523 result_reg,
5522 instr->hydrogen()->deoptimize_on_undefined(), 5524 instr->hydrogen()->deoptimize_on_undefined(),
(...skipping 1117 matching lines...) Expand 10 before | Expand all | Expand 10 after
6640 FixedArray::kHeaderSize - kPointerSize)); 6642 FixedArray::kHeaderSize - kPointerSize));
6641 __ bind(&done); 6643 __ bind(&done);
6642 } 6644 }
6643 6645
6644 6646
6645 #undef __ 6647 #undef __
6646 6648
6647 } } // namespace v8::internal 6649 } } // namespace v8::internal
6648 6650
6649 #endif // V8_TARGET_ARCH_IA32 6651 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698