Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: src/arm/lithium-codegen-arm.cc

Issue 14556007: Always tag number candidate as smi if it does not come from load-keyed. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5141 matching lines...) Expand 10 before | Expand all | Expand 10 after
5152 HLoadKeyed* load = HLoadKeyed::cast(value); 5152 HLoadKeyed* load = HLoadKeyed::cast(value);
5153 if (load->UsesMustHandleHole()) { 5153 if (load->UsesMustHandleHole()) {
5154 if (load->hole_mode() == ALLOW_RETURN_HOLE) { 5154 if (load->hole_mode() == ALLOW_RETURN_HOLE) {
5155 mode = NUMBER_CANDIDATE_IS_SMI_CONVERT_HOLE; 5155 mode = NUMBER_CANDIDATE_IS_SMI_CONVERT_HOLE;
5156 } else { 5156 } else {
5157 mode = NUMBER_CANDIDATE_IS_SMI_OR_HOLE; 5157 mode = NUMBER_CANDIDATE_IS_SMI_OR_HOLE;
5158 } 5158 }
5159 } else { 5159 } else {
5160 mode = NUMBER_CANDIDATE_IS_SMI; 5160 mode = NUMBER_CANDIDATE_IS_SMI;
5161 } 5161 }
5162 } else {
5163 mode = NUMBER_CANDIDATE_IS_SMI;
5162 } 5164 }
5163 } 5165 }
5164 5166
5165 EmitNumberUntagD(input_reg, result_reg, 5167 EmitNumberUntagD(input_reg, result_reg,
5166 instr->hydrogen()->deoptimize_on_undefined(), 5168 instr->hydrogen()->deoptimize_on_undefined(),
5167 instr->hydrogen()->deoptimize_on_minus_zero(), 5169 instr->hydrogen()->deoptimize_on_minus_zero(),
5168 instr->environment(), 5170 instr->environment(),
5169 mode); 5171 mode);
5170 } 5172 }
5171 5173
(...skipping 869 matching lines...) Expand 10 before | Expand all | Expand 10 after
6041 __ sub(scratch, result, Operand(index, LSL, kPointerSizeLog2 - kSmiTagSize)); 6043 __ sub(scratch, result, Operand(index, LSL, kPointerSizeLog2 - kSmiTagSize));
6042 __ ldr(result, FieldMemOperand(scratch, 6044 __ ldr(result, FieldMemOperand(scratch,
6043 FixedArray::kHeaderSize - kPointerSize)); 6045 FixedArray::kHeaderSize - kPointerSize));
6044 __ bind(&done); 6046 __ bind(&done);
6045 } 6047 }
6046 6048
6047 6049
6048 #undef __ 6050 #undef __
6049 6051
6050 } } // namespace v8::internal 6052 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698