components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc - Issue 1455333004: Add "q=preview" directive on main frame requests on poor networks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc

Issue 1455333004: Add "q=preview" directive on main frame requests on poor networks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@deciderAddLoFiHeader

Patch Set: thestig comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/about_flags.cc ('K') | « components/data_reduction_proxy/content/browser/content_lofi_decider_unittest.cc ('k') | components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc

index 5fd509ff978512f41f6921e82acd13f3b0beeff2..27fde6434941a9e941e7712208cd21ed37a63327 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc

@@ -180,7 +180,7 @@ void DataReductionProxyNetworkDelegate::OnBeforeSendProxyHeadersInternal(

bool is_using_lofi_mode =

lofi_decider->MaybeAddLoFiDirectiveToHeaders(*request, headers);

- if ((request->load_flags() & net::LOAD_MAIN_FRAME) != 0) {

+ if ((request->load_flags() & net::LOAD_MAIN_FRAME)) {

// TODO(megjablon): Need to switch to per page.

data_reduction_proxy_io_data_->SetLoFiModeActiveOnMainFrame(

is_using_lofi_mode);