components/data_reduction_proxy/core/common/lofi_decider.h - Issue 1455333004: Add "q=preview" directive on main frame requests on poor networks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/common/lofi_decider.h

Issue 1455333004: Add "q=preview" directive on main frame requests on poor networks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@deciderAddLoFiHeader

Patch Set: limit flag channels Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/common/data_reduction_proxy_switches.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/common/lofi_decider.h

diff --git a/components/data_reduction_proxy/core/common/lofi_decider.h b/components/data_reduction_proxy/core/common/lofi_decider.h

index 727b87b59927fe34b9e8bf159cdd1a54dd2aff48..da635106230f1fdbcbdb0c1dc9e5385b6448a9e5 100644

--- a/components/data_reduction_proxy/core/common/lofi_decider.h

+++ b/components/data_reduction_proxy/core/common/lofi_decider.h

@@ -26,8 +26,10 @@ class LoFiDecider {

// Returns true when Lo-Fi mode is on for the given |request|. If the

// |request| is using Lo-Fi mode, adds the "q=low" directive to the |headers|.

- // If the user is in the experiment control group and Lo-Fi is on, adds the

- // experiment directive "exp=lofi_active_control".

+ // If the |request| is using Lo-Fi preview mode, and it is a main frame

+ // request adds the "q=preview" and it is a main frame request directive to

+ // the |headers|. If the user is in the experiment control group and Lo-Fi is

+ // on, adds the experiment directive "exp=lofi_active_control".

virtual bool MaybeAddLoFiDirectiveToHeaders(

const net::URLRequest& request,

net::HttpRequestHeaders* headers) const = 0;