Export the functions needed by the libSSL in NSS 3.15.

Export the functions needed by the libSSL in NSS 3.15.

R=agl@chromium.org,rsleevi@chromium.org
BUG=233732
TEST=no build errors on Windows

[wtc, 2013-04-29 21:38:56]

If these functions are not exported, I get link errors on
Windows when doing a shared library build:

1>Link:
1>     Creating library ..\..\..\build\Debug\lib\crssl.lib and object
..\..\..\build\Debug\lib\crssl.exp
1>sslauth.obj : error LNK2019: unresolved external symbol _CERT_VerifyCert
referenced in function _SSL_AuthCertificate
1>sslauth.obj : error LNK2019: unresolved external symbol
_CERT_CacheOCSPResponseFromSideChannel referenced in function
_SSL_AuthCertificate
1>sslnonce.obj : error LNK2019: unresolved external symbol _SECITEM_FreeArray
referenced in function _ssl_DestroySID
1>ssl3con.obj : error LNK2001: unresolved external symbol _SECITEM_FreeArray
1>sslsock.obj : error LNK2001: unresolved external symbol _SECITEM_FreeArray
1>ssl3con.obj : error LNK2019: unresolved external symbol _SECITEM_AllocArray
referenced in function _ssl3_HandleCertificateStatus
1>sslsock.obj : error LNK2019: unresolved external symbol _SECITEM_DupArray
referenced in function _ssl_DupSocket
1>..\..\..\build\Debug\crssl.dll : fatal error LNK1120: 5 unresolved externals
1>
1>Build FAILED.

[agl, 2013-04-29 21:39:45]

lgtm

[Ryan Sleevi, 2013-04-29 21:49:27]

I'm inclined to say NACK, because I think there's some upstream issues, but we
could just roll those in later.

https://codereview.chromium.org/14544011/diff/1/nss/exports_win.def
File nss/exports_win.def (right):

https://codereview.chromium.org/14544011/diff/1/nss/exports_win.def#newcode54
nss/exports_win.def:54: CERT_VerifyCert
Do you have linker output for where this is being called?

I looked through your diffs for NSS 3.15, and I don't see any new calls - only
the updated signature.

https://codereview.chromium.org/14544011/diff/1/nss/exports_win.def#newcode197
nss/exports_win.def:197: SECITEM_AllocArray
BUG: This makes me think it's a bug in upstream NSS 3.15 that these are not
mapped through _Util wrappers, as all of SECUtil is. This ends up forcing a
direct dependency from libssl onto secutil, where today it tries to be done
dynamically.

[wtc, 2013-04-29 22:10:32]

https://codereview.chromium.org/14544011/diff/1/nss/exports_win.def
File nss/exports_win.def (right):

https://codereview.chromium.org/14544011/diff/1/nss/exports_win.def#newcode54
nss/exports_win.def:54: CERT_VerifyCert

On 2013/04/29 21:49:27, Ryan Sleevi wrote:
> Do you have linker output for where this is being called?
> 
> I looked through your diffs for NSS 3.15, and I don't see any new calls - only
> the updated signature.

The calls to CERT_VerifyCert and CERT_CacheOCSPResponseFromSideChannel
are in the SSL_AuthCertificate function. You can see them
in my CL for the NSS libSSL (as opposed to NSS proper):
https://chromiumcodereview.appspot.com/14522022/diff/30001/net/third_party/ns...

These calls are added in this upstream changeset:
https://hg.mozilla.org/projects/nss/rev/0b2ac9faa533

That changeset seems to contain two independent changes.
Just look at the change to sslauth.c.

https://codereview.chromium.org/14544011/diff/1/nss/exports_win.def#newcode197
nss/exports_win.def:197: SECITEM_AllocArray

It is OK for libssl3.so to depend on libnssutil3.so.

The _Util wrappers are only needed for functions that used
to be in libnss3.so.  When we added libnssutil3.so, we moved
those functions from libnss3.so to libnssutil3.so, but for
backward compatibility, wrappers for those functions still need
to be in libnss3.so. So we ended up with, for example,

libnss3.so: SECITEM_AllocItem (a wrapper)
libnssutil3.so: SECITEM_AllocItem_Util (the real function)

New functions in libnssutil3.so don't need the _Util wrappers.

[commit-bot: I haz the power, 2013-04-29 22:14:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wtc@chromium.org/14544011/1

[commit-bot: I haz the power, 2013-04-29 22:14:50]

Change committed as 197158