Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 14535004: Remove inout params from saturation helper func in XferEffect. (Closed)

Created:
7 years, 7 months ago by bsalomon
Modified:
7 years, 7 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Remove inout params from saturation helper func in XferEffect. Committed: http://code.google.com/p/skia/source/detail?r=8909

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -21 lines) Patch
M src/core/SkXfermode.cpp View 1 2 3 chunks +22 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bsalomon
This seems to fix the PVR issues in the saturation xfermode.
7 years, 7 months ago (2013-04-29 16:58:35 UTC) #1
robertphillips
lgtm + 1 question https://codereview.chromium.org/14535004/diff/3001/src/core/SkXfermode.cpp File src/core/SkXfermode.cpp (right): https://codereview.chromium.org/14535004/diff/3001/src/core/SkXfermode.cpp#newcode1310 src/core/SkXfermode.cpp:1310: "\t}\n", Why not just put ...
7 years, 7 months ago (2013-04-29 17:04:02 UTC) #2
jvanverth1
lgtm
7 years, 7 months ago (2013-04-29 17:04:24 UTC) #3
bsalomon
https://codereview.chromium.org/14535004/diff/3001/src/core/SkXfermode.cpp File src/core/SkXfermode.cpp (right): https://codereview.chromium.org/14535004/diff/3001/src/core/SkXfermode.cpp#newcode1310 src/core/SkXfermode.cpp:1310: "\t}\n", On 2013/04/29 17:04:02, robertphillips wrote: > Why not ...
7 years, 7 months ago (2013-04-29 17:07:02 UTC) #4
bsalomon
https://codereview.chromium.org/14535004/diff/3001/src/core/SkXfermode.cpp File src/core/SkXfermode.cpp (right): https://codereview.chromium.org/14535004/diff/3001/src/core/SkXfermode.cpp#newcode1310 src/core/SkXfermode.cpp:1310: "\t}\n", On 2013/04/29 17:04:02, robertphillips wrote: > Why not ...
7 years, 7 months ago (2013-04-29 17:12:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/14535004/10001
7 years, 7 months ago (2013-04-29 17:12:30 UTC) #6
commit-bot: I haz the power
7 years, 7 months ago (2013-04-29 17:36:17 UTC) #7
Message was sent while issue was closed.
Change committed as 8909

Powered by Google App Engine
This is Rietveld 408576698