Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: components/autofill/core/browser/form_field.h

Issue 1453193002: autofill: switch autofill_regexes to RE2 library (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address reviews Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/form_field.h
diff --git a/components/autofill/core/browser/form_field.h b/components/autofill/core/browser/form_field.h
index c27dc0896501289068f544ae65f7503bf372710c..1b1248e30ed9bcd86946c6cdded4dfbd8354ffeb 100644
--- a/components/autofill/core/browser/form_field.h
+++ b/components/autofill/core/browser/form_field.h
@@ -69,7 +69,7 @@ class FormField {
// Attempts to parse a form field with the given pattern. Returns true on
// success and fills |match| with a pointer to the field.
static bool ParseField(AutofillScanner* scanner,
- const base::string16& pattern,
+ const std::string& pattern,
AutofillField** match);
// Parses the stream of fields in |scanner| with regular expression |pattern|
@@ -78,7 +78,7 @@ class FormField {
// A |true| result is returned in the case of a successful match, false
// otherwise.
static bool ParseFieldSpecifics(AutofillScanner* scanner,
- const base::string16& pattern,
+ const std::string& pattern,
int match_type,
AutofillField** match);
@@ -89,7 +89,7 @@ class FormField {
// change.
static ParseNameLabelResult ParseNameAndLabelSeparately(
AutofillScanner* scanner,
- const base::string16& pattern,
+ const std::string& pattern,
int match_type,
AutofillField** match);
@@ -123,14 +123,14 @@ class FormField {
// Returns |true| if a match is found according to |match_type|, and |false|
// otherwise.
static bool MatchAndAdvance(AutofillScanner* scanner,
- const base::string16& pattern,
+ const std::string& pattern,
int match_type,
AutofillField** match);
// Matches the regular expression |pattern| against the components of |field|
// as specified in the |match_type| bit field (see |MatchType|).
static bool Match(const AutofillField* field,
- const base::string16& pattern,
+ const std::string& pattern,
int match_type);
// Perform a "pass" over the |fields| where each pass uses the supplied

Powered by Google App Engine
This is Rietveld 408576698