Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 14522003: Fix arm port of tracking field representations. Based on Rodolph Perfetta's comments (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.h ('k') | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2102 matching lines...) Expand 10 before | Expand all | Expand 10 after
2113 context = UseRegister(instr->context()); 2113 context = UseRegister(instr->context());
2114 value = UseRegister(instr->value()); 2114 value = UseRegister(instr->value());
2115 } 2115 }
2116 LInstruction* result = new(zone()) LStoreContextSlot(context, value); 2116 LInstruction* result = new(zone()) LStoreContextSlot(context, value);
2117 return instr->RequiresHoleCheck() ? AssignEnvironment(result) : result; 2117 return instr->RequiresHoleCheck() ? AssignEnvironment(result) : result;
2118 } 2118 }
2119 2119
2120 2120
2121 LInstruction* LChunkBuilder::DoLoadNamedField(HLoadNamedField* instr) { 2121 LInstruction* LChunkBuilder::DoLoadNamedField(HLoadNamedField* instr) {
2122 LOperand* obj = UseRegisterAtStart(instr->object()); 2122 LOperand* obj = UseRegisterAtStart(instr->object());
2123 LOperand* temp = instr->representation().IsDouble() ? TempRegister() : NULL; 2123 return DefineAsRegister(new(zone()) LLoadNamedField(obj));
2124 ASSERT(temp == NULL || FLAG_track_double_fields);
2125 return DefineAsRegister(new(zone()) LLoadNamedField(obj, temp));
2126 } 2124 }
2127 2125
2128 2126
2129 LInstruction* LChunkBuilder::DoLoadNamedFieldPolymorphic( 2127 LInstruction* LChunkBuilder::DoLoadNamedFieldPolymorphic(
2130 HLoadNamedFieldPolymorphic* instr) { 2128 HLoadNamedFieldPolymorphic* instr) {
2131 ASSERT(instr->representation().IsTagged()); 2129 ASSERT(instr->representation().IsTagged());
2132 if (instr->need_generic()) { 2130 if (instr->need_generic()) {
2133 LOperand* obj = UseFixed(instr->object(), r0); 2131 LOperand* obj = UseFixed(instr->object(), r0);
2134 LLoadNamedFieldPolymorphic* result = 2132 LLoadNamedFieldPolymorphic* result =
2135 new(zone()) LLoadNamedFieldPolymorphic(obj); 2133 new(zone()) LLoadNamedFieldPolymorphic(obj);
(...skipping 493 matching lines...) Expand 10 before | Expand all | Expand 10 after
2629 2627
2630 2628
2631 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2629 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2632 LOperand* object = UseRegister(instr->object()); 2630 LOperand* object = UseRegister(instr->object());
2633 LOperand* index = UseRegister(instr->index()); 2631 LOperand* index = UseRegister(instr->index());
2634 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2632 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2635 } 2633 }
2636 2634
2637 2635
2638 } } // namespace v8::internal 2636 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.h ('k') | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698