Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 14518004: Make resize-events test platform-independent. (Closed)

Created:
7 years, 8 months ago by dshwang
Modified:
7 years, 7 months ago
Reviewers:
jamesr
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Make resize-events test platform-independent. resize-events test checks whether a resize event is fired or not. An only text test can satisfy the purpose of this test. This patch simplifies this test to maintain this test easily. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149286

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -94 lines) Patch
M LayoutTests/fast/events/resize-events.html View 2 chunks +2 lines, -1 line 0 comments Download
A LayoutTests/fast/events/resize-events-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
D LayoutTests/platform/chromium-android/fast/events/resize-events-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/platform/chromium-android/fast/events/resize-events-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/platform/chromium-linux/fast/events/resize-events-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/platform/chromium-mac-lion/fast/events/resize-events-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/platform/chromium-mac-snowleopard/fast/events/resize-events-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/platform/chromium-mac/fast/events/resize-events-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/platform/chromium-mac/fast/events/resize-events-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/platform/chromium-win/fast/events/resize-events-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/platform/chromium-win/fast/events/resize-events-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dshwang
7 years, 8 months ago (2013-04-26 15:42:22 UTC) #1
jamesr
awesome! lgtm
7 years, 8 months ago (2013-04-26 18:06:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/14518004/1
7 years, 7 months ago (2013-04-28 07:44:38 UTC) #3
dshwang
On 2013/04/26 18:06:19, jamesr wrote: > awesome! lgtm Thank you for your lgtm!!
7 years, 7 months ago (2013-04-28 07:44:44 UTC) #4
commit-bot: I haz the power
7 years, 7 months ago (2013-04-28 08:27:39 UTC) #5
Message was sent while issue was closed.
Change committed as 149286

Powered by Google App Engine
This is Rietveld 408576698