Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1210)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14514003: Make OSX App Launcher Launchable from the Dock. (Closed)

Created:
7 years, 7 months ago by tapted
Modified:
7 years, 7 months ago
Reviewers:
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, sadrul, ben+watch_chromium.org, tfarina, sail+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Make OSX App Launcher Launchable from the Dock. BUG=138633

Patch Set 1 #

Patch Set 2 : pull more stuff out of win #

Patch Set 3 : more #

Patch Set 4 : fix windows, enable test, remove binary for x-platform work #

Patch Set 5 : fix browsertest compile #

Patch Set 6 : see what it makes sense to cut out #

Patch Set 7 : rebase off cl14603002 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -3 lines) Patch
M apps/DEPS View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M apps/app_shim/app_shim_host_mac.h View 1 2 3 4 5 5 chunks +10 lines, -0 lines 0 comments Download
M apps/app_shim/app_shim_host_mac.cc View 1 2 3 4 5 8 chunks +32 lines, -2 lines 0 comments Download
M apps/app_shim/app_shim_messages.h View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/app/chrome_main_app_mode_mac.mm View 1 2 3 4 5 6 4 chunks +14 lines, -0 lines 0 comments Download
M chrome/app/chromium_strings.grd View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/theme/chrome_unscaled_resources.grd View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/app/theme/chromium/app_list_128.png View 4 5 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/ui/app_list/app_list_dismiss_observer_mac.h View 1 2 3 4 5 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service.cc View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_impl.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_impl.cc View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download
chrome/browser/ui/app_list/app_list_service_mac.h View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_mac.mm View 1 2 3 4 5 6 8 chunks +118 lines, -1 line 0 comments Download
M chrome/browser/web_applications/web_app.h View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/web_applications/web_app_mac.h View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/web_applications/web_app_mac.mm View 1 2 3 4 5 3 chunks +17 lines, -1 line 0 comments Download
M chrome/browser/web_applications/web_app_mac_unittest.mm View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/mac/app_mode_common.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/mac/app_mode_common.mm View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ui/app_list/cocoa/app_list_view_controller.mm View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698