include/v8.h - Issue 14509012: HasOnlyAsciiChars can return incorrect results. Fixup usages and rename.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/v8.h

Issue 14509012: HasOnlyAsciiChars can return incorrect results. Fixup usages and rename. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: fixed typo Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: include/v8.h

diff --git a/include/v8.h b/include/v8.h

index 555fe19bd2707d54427810b110fd988f742fecce..f300884965233b2d92eac5099e0731ab2bad7c97 100644

--- a/include/v8.h

+++ b/include/v8.h

@@ -1183,12 +1183,10 @@ class V8EXPORT String : public Primitive {

int Utf8Length() const;

/**

- * A fast conservative check for non-ASCII characters. May

- * return true even for ASCII strings, but if it returns

- * false you can be sure that all characters are in the range

- * 0-127.

+ * This function is no longer useful.

- bool MayContainNonAscii() const;

+ // TODO(dcarney): deprecate

tfarina 2013/04/26 16:31:52 can we use V8_DEPRECATED?

+ V8_INLINE(bool MayContainNonAscii()) const { return true; }

/**

* Returns whether this string contains only one byte data.

« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »