chrome/browser/extensions/api/tabs/tabs_api.cc - Issue 14494004: Added the 'Translation Logs' tab to chrome://translate-internals/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs_api.cc

Issue 14494004: Added the 'Translation Logs' tab to chrome://translate-internals/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: (Rebasing) Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autofill/autofill_browsertest.cc ('k') | chrome/browser/resources/translate_internals/detection_logs.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/tabs/tabs_api.cc

diff --git a/chrome/browser/extensions/api/tabs/tabs_api.cc b/chrome/browser/extensions/api/tabs/tabs_api.cc

index 57a49151cba20ccddda4d123fcf6e49212c1016d..3370ee81751015d9b81101baf6948b6632b401e4 100644

--- a/chrome/browser/extensions/api/tabs/tabs_api.cc

+++ b/chrome/browser/extensions/api/tabs/tabs_api.cc

@@ -62,6 +62,7 @@

#include "chrome/common/extensions/message_bundle.h"

#include "chrome/common/extensions/permissions/permissions_data.h"

#include "chrome/common/extensions/user_script.h"

+#include "chrome/common/language_detection_details.h"

#include "chrome/common/pref_names.h"

#include "chrome/common/url_constants.h"

#include "components/user_prefs/pref_registry_syncable.h"

@@ -1936,8 +1937,11 @@ void TabsDetectLanguageFunction::Observe(

const content::NotificationSource& source,

const content::NotificationDetails& details) {

std::string language;

- if (type == chrome::NOTIFICATION_TAB_LANGUAGE_DETERMINED)

- language = *content::Details<std::string>(details).ptr();

+ if (type == chrome::NOTIFICATION_TAB_LANGUAGE_DETERMINED) {

+ const LanguageDetectionDetails* lang_det_details =

+ content::Details<const LanguageDetectionDetails>(details).ptr();

+ language = lang_det_details->adopted_language;

+ }

registrar_.RemoveAll();