Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 14493016: Fix handling of 'inherit' and 'initial' for grid lines (Closed)

Created:
7 years, 8 months ago by Julien - ping for review
Modified:
7 years, 8 months ago
Reviewers:
eseidel
CC:
blink-reviews, ojan, esprehn
Visibility:
Public.

Description

Fix handling of 'inherit' and 'initial' for grid lines 'initial' and 'inherit' are always allowed values for CSS properties. As the CSSParser handles them automatically, those 2 values were never taken care of in StyleResolver, leading to ASSERTs triggering. While touching this code, renamed the RenderStyle grid line accessors as it shouldn't ambiguous to whom they apply. BUG=234198 TESTS=fast/css-grid-layout/grid-item-column-row-get-set.html fast/css-grid-layout/grid-item-end-after-get-set.html fast/css-grid-layout/grid-item-start-before-get-set.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149257

Patch Set 1 #

Patch Set 2 : Take 2: Forgot the code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+305 lines, -29 lines) Patch
M LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set.html View 1 chunk +10 lines, -0 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set-expected.txt View 1 chunk +40 lines, -0 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-item-end-after-get-set.html View 1 chunk +10 lines, -0 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-item-end-after-get-set-expected.txt View 1 chunk +40 lines, -0 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set.html View 1 chunk +10 lines, -0 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set-expected.txt View 1 chunk +40 lines, -0 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/resources/grid-item-column-row-parsing-utils.js View 1 chunk +118 lines, -0 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/css/StyleResolver.cpp View 1 2 chunks +14 lines, -10 lines 0 comments Download
M Source/core/rendering/RenderGrid.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 1 3 chunks +13 lines, -9 lines 0 comments Download
M Source/core/rendering/style/StyleGridItemData.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Julien - ping for review
7 years, 8 months ago (2013-04-25 16:57:23 UTC) #1
eseidel
lgtm
7 years, 8 months ago (2013-04-27 08:55:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/14493016/3001
7 years, 8 months ago (2013-04-27 08:55:55 UTC) #3
commit-bot: I haz the power
7 years, 8 months ago (2013-04-27 09:01:58 UTC) #4
Message was sent while issue was closed.
Change committed as 149257

Powered by Google App Engine
This is Rietveld 408576698