Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 14473014: Fix USB Permission string (Closed)

Created:
7 years, 8 months ago by Bei Zhang
Modified:
7 years, 6 months ago
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Fix USB Permission string to UI-review approved Strings: How about ? Access the USB device X from Y If X is missing: Access the USB device from Y If both are missing: Access the USB device BUG=229697 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201980

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix license info year / Merge to origin/master #

Patch Set 3 : Merge to origin/master #

Patch Set 4 : Disable USBDevicePermissionTest on platforms does not support extension #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -28 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/permissions/usb_device_permission.cc View 1 chunk +21 lines, -22 lines 0 comments Download
A chrome/common/extensions/permissions/usb_device_permission_unittest.cc View 1 2 3 1 chunk +60 lines, -0 lines 1 comment Download

Messages

Total messages: 17 (0 generated)
Bei Zhang
7 years, 7 months ago (2013-04-30 19:41:11 UTC) #1
Bei Zhang
Hi Antony, Please review. Thanks, Bei
7 years, 7 months ago (2013-05-07 20:08:59 UTC) #2
miket_OOO
lgtm https://codereview.chromium.org/14473014/diff/1/chrome/common/extensions/permissions/usb_device_permission_unittest.cc File chrome/common/extensions/permissions/usb_device_permission_unittest.cc (right): https://codereview.chromium.org/14473014/diff/1/chrome/common/extensions/permissions/usb_device_permission_unittest.cc#newcode1 chrome/common/extensions/permissions/usb_device_permission_unittest.cc:1: // Copyright (c) 2012 The Chromium Authors. All ...
7 years, 7 months ago (2013-05-07 20:13:59 UTC) #3
asargent_no_longer_on_chrome
lgtm
7 years, 7 months ago (2013-05-07 21:05:17 UTC) #4
Bei Zhang
Thanks for reviewing! https://codereview.chromium.org/14473014/diff/1/chrome/common/extensions/permissions/usb_device_permission_unittest.cc File chrome/common/extensions/permissions/usb_device_permission_unittest.cc (right): https://codereview.chromium.org/14473014/diff/1/chrome/common/extensions/permissions/usb_device_permission_unittest.cc#newcode1 chrome/common/extensions/permissions/usb_device_permission_unittest.cc:1: // Copyright (c) 2012 The Chromium ...
7 years, 7 months ago (2013-05-08 20:07:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ikarienator@chromium.org/14473014/7001
7 years, 7 months ago (2013-05-08 20:07:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ikarienator@chromium.org/14473014/28001
7 years, 7 months ago (2013-05-08 20:42:24 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=112455
7 years, 7 months ago (2013-05-08 23:01:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ikarienator@chromium.org/14473014/40001
7 years, 7 months ago (2013-05-09 17:54:04 UTC) #9
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) googleurl_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=51155
7 years, 7 months ago (2013-05-09 18:10:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ikarienator@chromium.org/14473014/40001
7 years, 7 months ago (2013-05-09 21:08:23 UTC) #11
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
7 years, 7 months ago (2013-05-10 03:31:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ikarienator@chromium.org/14473014/60001
7 years, 7 months ago (2013-05-23 16:56:22 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ikarienator@chromium.org/14473014/84001
7 years, 7 months ago (2013-05-23 19:47:33 UTC) #14
commit-bot: I haz the power
Change committed as 201980
7 years, 7 months ago (2013-05-24 06:24:23 UTC) #15
Dan Beam
https://chromiumcodereview.appspot.com/14473014/diff/84001/chrome/common/extensions/permissions/usb_device_permission_unittest.cc File chrome/common/extensions/permissions/usb_device_permission_unittest.cc (right): https://chromiumcodereview.appspot.com/14473014/diff/84001/chrome/common/extensions/permissions/usb_device_permission_unittest.cc#newcode41 chrome/common/extensions/permissions/usb_device_permission_unittest.cc:41: base::ListValue* permission_list = new base::ListValue(); this probably ought to ...
7 years, 7 months ago (2013-05-24 07:50:30 UTC) #16
Bei Zhang
7 years, 6 months ago (2013-05-31 21:30:17 UTC) #17
Message was sent while issue was closed.
Fixed by Dan Beam: https://codereview.chromium.org/15663003
Thanks Dan!

Powered by Google App Engine
This is Rietveld 408576698