Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 14472011: Update ALLOW_THIS_IN_INITIALIZER_LIST macro to reflect its deprecatation. (Closed)

Created:
7 years, 8 months ago by scherkus (not reviewing)
Modified:
7 years, 8 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Update ALLOW_THIS_IN_INITIALIZER_LIST macro to reflect its deprecatation. In addition move C4355 to list of sanctioned compiler warning suppressions. The warning was disabled globally for ~2 years, meaning the macro wasn't providing any value. Refer to bug and chromium-dev@ discussion for details. BUG=234765 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196671

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -13 lines) Patch
M base/compiler_specific.h View 1 chunk +7 lines, -10 lines 0 comments Download
M build/common.gypi View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scherkus (not reviewing)
Touching build/compiler_specific.h ~= clobber build :( I'll try to land this manually during non-PST hours ...
7 years, 8 months ago (2013-04-24 18:09:38 UTC) #1
darin (slow to review)
LGTM++
7 years, 8 months ago (2013-04-25 18:17:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/14472011/5001
7 years, 8 months ago (2013-04-26 05:30:34 UTC) #3
commit-bot: I haz the power
7 years, 8 months ago (2013-04-26 08:12:08 UTC) #4
Message was sent while issue was closed.
Change committed as 196671

Powered by Google App Engine
This is Rietveld 408576698