Issue 14472003: Merged r14169 into 3.17 branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14472003: Merged r14169 into 3.17 branch. (Closed)

Created:
7 years, 8 months ago by Yang

Modified:
7 years, 8 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/3.17

Visibility:
Public.

Merged r14169 into 3.17 branch. Fix worst-case behavior of MergeRemovableSimulates(). BUG=v8:2612 R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14418

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -38 lines)			Patch
M	src/hydrogen.cc	View		2 chunks	+24 lines, -18 lines	0 comments	Download
M	src/hydrogen-instructions.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/hydrogen-instructions.cc	View		2 chunks	+16 lines, -11 lines	0 comments	Download
M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/mjsunit.status	View		1 chunk	+1 line, -0 lines	0 comments	Download
A +	test/mjsunit/regress/regress-2612.js	View	1	1 chunk	+42 lines, -7 lines	0 comments	Download

Total messages: 4 (0 generated)

Jakob Kummerow

LGTM. The mjsunit.status file introduces a new entry for a test that's not contained in ...

7 years, 8 months ago (2013-04-24 14:18:33 UTC) #2

Yang

On 2013/04/24 14:18:33, Jakob wrote: > LGTM. > > The mjsunit.status file introduces a new ...

7 years, 8 months ago (2013-04-24 14:20:32 UTC) #3

Yang

7 years, 8 months ago (2013-04-24 14:21:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r14418 (presubmit successful).