Issue 14471033: Don't prerender if an interstitial would be shown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14471033: Don't prerender if an interstitial would be shown. (Closed)

Created:
7 years, 8 months ago by Adrian Kuegel

Modified:
7 years, 7 months ago

Reviewers:
cbentzel, tburkard

CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, mmenke

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't prerender if an interstitial would be shown. For managed users we would show an interstitial for URLs which should be blocked. We can check early if the URL would be blocked and stop prerendering. BUG=234231 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196709

Patch Set 1 #

Patch Set 2 : Rebase to ToT. #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -0 lines)			Patch
	M	chrome/browser/prerender/prerender_manager.cc	View	1	2 chunks	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akuegel@chromium.org/14471033/6001

7 years, 8 months ago (2013-04-26 08:14:16 UTC) #3

cbentzel

Seems like a new FINAL_STATUS should be added so we can debug why prerenders are ...

7 years, 7 months ago (2013-05-06 17:20:20 UTC) #5

Adrian Kuegel

7 years, 7 months ago (2013-05-07 08:01:22 UTC) #6

Message was sent while issue was closed.

Currently there should be (almost) no blockings due to this feature, because
managed users are behind a flag. But I guess if you want to know why prerenders
are blocked, another FINAL_STATUS should be added when we enable that feature.
It is also possible that maybe we don't need to block prerenders for our feature
at all, we are currently changing some logic regarding the interstitial page.

Expand Messages | Collapse Messages