Issue 14467003: Remove ENABLE_DIALOG_ELEMENT

Issue 14467003: Remove ENABLE_DIALOG_ELEMENT (Closed)

Created:
7 years, 8 months ago by Julien - ping for review

Modified:
7 years, 8 months ago

Reviewers:
falken, abarth-chromium

CC:
blink-reviews, apavlov+blink_chromium.org, jchaffraix+rendering, darktears

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove ENABLE_DIALOG_ELEMENT The flag was always enabled on Chromium and the feature is under a runtime flag so the #ifdef's can be safely removed. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149072

Patch Set 1 #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -93 lines)			Patch
M	Source/WebKit/chromium/src/WebRuntimeFeatures.cpp	View	1 chunk	+0 lines, -8 lines	1 comment	Download
M	Source/core/css/StyleResolver.cpp	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	Source/core/css/html.css	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	Source/core/dom/ContextFeatures.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	Source/core/dom/Document.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	Source/core/dom/Document.cpp	View	3 chunks	+0 lines, -4 lines	0 comments	Download
M	Source/core/dom/Element.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	Source/core/dom/Element.cpp	View	4 chunks	+0 lines, -8 lines	0 comments	Download
M	Source/core/dom/ElementRareData.h	View	3 chunks	+0 lines, -6 lines	0 comments	Download
M	Source/core/dom/NodeRenderingContext.cpp	View	6 chunks	+0 lines, -8 lines	0 comments	Download
M	Source/core/features.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLDialogElement.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	Source/core/html/HTMLDialogElement.cpp	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	Source/core/html/HTMLDialogElement.idl	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLTagNames.in	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/page/DOMWindow.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/page/RuntimeEnabledFeatures.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	Source/core/page/RuntimeEnabledFeatures.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/rendering/RenderLayer.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/rendering/RenderLayer.cpp	View	5 chunks	+0 lines, -7 lines	0 comments	Download
M	Source/core/rendering/RenderObject.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/testing/InternalSettings.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/testing/InternalSettings.cpp	View	3 chunks	+1 line, -10 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/14467003/1

7 years, 8 months ago (2013-04-25 03:51:38 UTC) #4

commit-bot: I haz the power

Presubmit check for 14467003-1 failed and returned exit status 1. INFO:root:Found 23 file(s). Running presubmit ...

7 years, 8 months ago (2013-04-25 03:51:48 UTC) #5

abarth-chromium

https://chromiumcodereview.appspot.com/14467003/diff/1/Source/WebKit/chromium/src/WebRuntimeFeatures.cpp File Source/WebKit/chromium/src/WebRuntimeFeatures.cpp (left): https://chromiumcodereview.appspot.com/14467003/diff/1/Source/WebKit/chromium/src/WebRuntimeFeatures.cpp#oldcode432 Source/WebKit/chromium/src/WebRuntimeFeatures.cpp:432: #endif LGTM

7 years, 8 months ago (2013-04-25 03:59:33 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/14467003/1

7 years, 8 months ago (2013-04-25 03:59:59 UTC) #7

Message was sent while issue was closed.

Change committed as 149072

Expand Messages | Collapse Messages