Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1014)

Issue 14466008: Switch speech synthesis from compile-flag to runtime-flag. (Closed)

Created:
7 years, 7 months ago by dmazzoni
Modified:
7 years, 7 months ago
CC:
blink-reviews, jamesr, jeez, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Switch speech synthesis from compile-flag to runtime-flag. BUG=171887 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149457

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add to RuntimeEnabledFeatures.in #

Patch Set 3 : Rebase, switch to RuntimeEnabledFeatures.in #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -127 lines) Patch
M Source/core/core.gyp/core.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/EventNames.in View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/EventTargetFactory.in View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/features.gypi View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/page/RuntimeEnabledFeatures.in View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/platform/PlatformSpeechSynthesis.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/platform/PlatformSpeechSynthesisUtterance.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/platform/PlatformSpeechSynthesisUtterance.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/platform/PlatformSpeechSynthesisVoice.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/platform/PlatformSpeechSynthesisVoice.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/platform/PlatformSpeechSynthesizer.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/platform/PlatformSpeechSynthesizer.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/platform/chromium/PlatformSpeechSynthesizerChromium.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/platform/chromium/support/WebSpeechSynthesisUtterance.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/platform/chromium/support/WebSpeechSynthesisVoice.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/platform/chromium/support/WebSpeechSynthesizerClientImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/platform/chromium/support/WebSpeechSynthesizerClientImpl.cpp View 2 chunks +0 lines, -18 lines 0 comments Download
M Source/core/platform/mock/PlatformSpeechSynthesizerMock.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/platform/mock/PlatformSpeechSynthesizerMock.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/testing/Internals.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 2 3 chunks +0 lines, -4 lines 0 comments Download
M Source/modules/speech/DOMWindowSpeechSynthesis.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/modules/speech/DOMWindowSpeechSynthesis.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/modules/speech/DOMWindowSpeechSynthesis.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/modules/speech/SpeechSynthesis.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/modules/speech/SpeechSynthesis.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/modules/speech/SpeechSynthesis.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesisEvent.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/modules/speech/SpeechSynthesisEvent.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/modules/speech/SpeechSynthesisEvent.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesisUtterance.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/modules/speech/SpeechSynthesisUtterance.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/modules/speech/SpeechSynthesisUtterance.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesisVoice.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/modules/speech/SpeechSynthesisVoice.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/modules/speech/SpeechSynthesisVoice.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/chromium/SpeechSynthesisChromium.cpp View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dmazzoni
7 years, 7 months ago (2013-04-29 21:44:23 UTC) #1
eseidel
LGTM. You and I are going to be fighting over RUntimeEnabledFeatures today. :) https://codereview.chromium.org/14466008/diff/1/Source/core/page/RuntimeEnabledFeatures.h File ...
7 years, 7 months ago (2013-04-29 21:50:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/14466008/6001
7 years, 7 months ago (2013-04-29 21:59:32 UTC) #3
commit-bot: I haz the power
Retried try job too often on blink_bare_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_bare_presubmit&number=139
7 years, 7 months ago (2013-04-29 22:08:17 UTC) #4
dmazzoni
7 years, 7 months ago (2013-04-30 05:51:11 UTC) #5
abarth-chromium
API change LGTM
7 years, 7 months ago (2013-04-30 06:06:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/14466008/16001
7 years, 7 months ago (2013-04-30 19:29:44 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-04-30 20:05:35 UTC) #8
Message was sent while issue was closed.
Change committed as 149457

Powered by Google App Engine
This is Rietveld 408576698