Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1446323002: Early out in OnFocusedNodeChanged if there's no view. (Closed)

Created:
5 years, 1 month ago by wjmaclean
Modified:
5 years, 1 month ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Early out in OnFocusedNodeChanged if there's no view. The function RenderViewHostImpl::OnFocusedNodeChanged() currently crashes if there's no view, which is a possibility (see check near top of function). This CL adds an early out to avoid the crash. BUG=555532 Committed: https://crrev.com/8c10dab2a6e5d7cb3c6c1f775202426a5171f69c Cr-Commit-Position: refs/heads/master@{#359935}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1446323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1446323002/1
5 years, 1 month ago (2015-11-16 18:39:31 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-16 19:42:07 UTC) #4
wjmaclean
avi@ - small cl, ptal?
5 years, 1 month ago (2015-11-16 20:37:08 UTC) #7
Avi (use Gerrit)
lgtm
5 years, 1 month ago (2015-11-16 21:56:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1446323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1446323002/1
5 years, 1 month ago (2015-11-16 21:57:24 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-16 22:04:37 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 22:05:23 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c10dab2a6e5d7cb3c6c1f775202426a5171f69c
Cr-Commit-Position: refs/heads/master@{#359935}

Powered by Google App Engine
This is Rietveld 408576698