Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Issue 14455006: Do not retry uploading to blobstore on HTTP 500, regenerate a new url first. (Closed)

Created:
7 years, 8 months ago by M-A Ruel
Modified:
7 years, 8 months ago
Reviewers:
csharp
CC:
chromium-reviews, csharp+cc_chromium.org, vadimsh+cc_chromium.org, maruel+cc_chromium.org
Visibility:
Public.

Description

Do not retry uploading to blobstore on HTTP 500, regenerate a new url first. This is important since after an HTTP 500, the temporary url is likely invalid. R=csharp@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=196770

Patch Set 1 #

Patch Set 2 : Better #

Patch Set 3 : Rebasef of 14383005 #

Total comments: 2

Patch Set 4 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -12 lines) Patch
M isolateserver_archive.py View 1 2 3 1 chunk +18 lines, -9 lines 0 comments Download
M run_isolated.py View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M tests/isolateserver_archive_test.py View 1 2 3 2 chunks +60 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
M-A Ruel
The CL exploded a bit so I'm fine if you prefer me to split it ...
7 years, 8 months ago (2013-04-26 16:39:01 UTC) #1
csharp
On 2013/04/26 16:39:01, Marc-Antoine Ruel wrote: > The CL exploded a bit so I'm fine ...
7 years, 8 months ago (2013-04-26 17:14:06 UTC) #2
M-A Ruel
Now much simpler
7 years, 8 months ago (2013-04-26 17:31:36 UTC) #3
csharp
lgtm https://codereview.chromium.org/14455006/diff/4001/isolateserver_archive.py File isolateserver_archive.py (right): https://codereview.chromium.org/14455006/diff/4001/isolateserver_archive.py#newcode139 isolateserver_archive.py:139: content_type, body = encode_multipart_formdata( Move this out of ...
7 years, 8 months ago (2013-04-26 17:51:58 UTC) #4
M-A Ruel
https://codereview.chromium.org/14455006/diff/4001/isolateserver_archive.py File isolateserver_archive.py (right): https://codereview.chromium.org/14455006/diff/4001/isolateserver_archive.py#newcode139 isolateserver_archive.py:139: content_type, body = encode_multipart_formdata( On 2013/04/26 17:51:58, csharp wrote: ...
7 years, 8 months ago (2013-04-26 17:56:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/14455006/8001
7 years, 8 months ago (2013-04-26 17:56:30 UTC) #6
commit-bot: I haz the power
7 years, 8 months ago (2013-04-26 17:57:43 UTC) #7
Message was sent while issue was closed.
Change committed as 196770

Powered by Google App Engine
This is Rietveld 408576698