Issue 14449007: Simplify `gcc_version' check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14449007: Simplify `gcc_version' check. (Closed)

Created:
7 years, 7 months ago by Raphael Kubo da Costa (rakuco)

Modified:
7 years, 7 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
http://src.chromium.org/svn/trunk/deps/third_party/hunspell/

Visibility:
Public.

More Reviews

Description

Simplify `gcc_version' check. gcc_version is always defined after r196910 (to 0 by default, and a meaningful value when GCC is used in the appropriate platforms), so we can back out r196565 and use a simpler check. R=thakis@chromium.org BUG=

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	hunspell.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/14449007/1

7 years, 7 months ago (2013-04-30 07:55:58 UTC) #3

Message was sent while issue was closed.

Change committed as 197309

Expand Messages | Collapse Messages