Enable fastbuild=1 on clang/mac

Enable fastbuild=1 on clang/mac

Before:
$ GYP_DEFINES="disable_nacl=1 fastbuild=1" CC=clang CXX=clang++ python build/gyp_chromium
$ ninja -C out/Release -t clean
$ time PATH=/path/to/goma:/path/to/chromium/src/third_party/llvm-build/Release+Asserts/bin:$PATH ninja -C out/Release -j 50 chrome
..
real    20m28.627s
user    9m20.091s
sys     2m43.130s

After:
$ GYP_DEFINES="disable_nacl=1 fastbuild=1" CC=clang CXX=clang++ python build/gyp_chromium
$ ninja -C out/Release -t clean
$ time PATH=/path/to/goma:/path/to/chromium/src/third_party/llvm-build/Release+Asserts/bin:$PATH ninja -C out/Release -j 50 chrome
...
real    8m55.293s
user    9m33.869s
sys     2m29.931s

R=thakis,shinyak,ilevy
BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196121

[Nico, 2013-04-24 05:22:22]

:-/ This was broken by ilevy in
https://chromiumcodereview.appspot.com/11364088/diff/4001/build/common.gypi

Since this is set in both branches, can you lift it out of the conditional and
put it above? xcode_settings is only used on mac too, so you don't need to check
of OS==mac either.

[Fumitoshi Ukai, 2013-04-24 05:33:22]

On 2013/04/24 05:22:22, Nico wrote:
> :-/ This was broken by ilevy in
> https://chromiumcodereview.appspot.com/11364088/diff/4001/build/common.gypi
> 
> Since this is set in both branches, can you lift it out of the conditional and
> put it above? xcode_settings is only used on mac too, so you don't need to
check
> of OS==mac either.

Done.

[Nico, 2013-04-24 05:35:05]

lgtm!

[Nico, 2013-04-24 05:35:36]

(and nice catch!)

[commit-bot: I haz the power, 2013-04-24 05:38:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ukai@chromium.org/14445005/2002

[shinyak, 2013-04-24 06:01:03]

Recently I've filed a bug about this, but immediately marked as WONTFIX :-(

https://code.google.com/p/chromium/issues/detail?id=234059

I hope this patch will improve our productivity!

[commit-bot: I haz the power, 2013-04-24 08:56:22]

Retried try job too often on win_rel for step(s) sync_integration_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-04-24 10:03:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ukai@chromium.org/14445005/2002

[commit-bot: I haz the power, 2013-04-24 11:42:32]

Change committed as 196121