pkg/compiler/lib/src/cps_ir/type_propagation.dart - Issue 1444363002: dart2js cps: Global value numbering and loop-invariant code motion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/cps_ir/type_propagation.dart

Issue 1444363002: dart2js cps: Global value numbering and loop-invariant code motion. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Add test case Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/cps_ir/type_propagation.dart

diff --git a/pkg/compiler/lib/src/cps_ir/type_propagation.dart b/pkg/compiler/lib/src/cps_ir/type_propagation.dart

index 9d1a33523cc5b5146afa8fc69e2fa454f71e3ec1..5e9adf4cc0878bd19f84a5e89165723a3de52885 100644

--- a/pkg/compiler/lib/src/cps_ir/type_propagation.dart

+++ b/pkg/compiler/lib/src/cps_ir/type_propagation.dart

@@ -3110,6 +3110,7 @@ class TypePropagationVisitor implements Visitor {

@override

void visitGetIndex(GetIndex node) {

AbstractValue input = getValue(node.object.definition);

+ node.objectIsNotNull = input.isDefinitelyNotNull;

setValue(node, nonConstant(typeSystem.elementTypeOfIndexable(input.type)));

}