Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: scripts/master/factory/gclient_factory.py

Issue 14440005: Rework how bots get the version of Blink. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: fix typo in devtools master.cfg Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « scripts/master/factory/commands.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Utility classes to generate and manage a BuildFactory to be passed to a 5 """Utility classes to generate and manage a BuildFactory to be passed to a
6 builder dictionary as the 'factory' member, for each builder in c['builders']. 6 builder dictionary as the 'factory' member, for each builder in c['builders'].
7 7
8 Specifically creates a base BuildFactory that will execute a gclient checkout 8 Specifically creates a base BuildFactory that will execute a gclient checkout
9 first.""" 9 first."""
10 10
(...skipping 283 matching lines...) Expand 10 before | Expand all | Expand 10 after
294 # Get variables needed for the update. 294 # Get variables needed for the update.
295 env = factory_properties.get('gclient_env', {}) 295 env = factory_properties.get('gclient_env', {})
296 timeout = factory_properties.get('gclient_timeout') 296 timeout = factory_properties.get('gclient_timeout')
297 297
298 no_gclient_branch = factory_properties.get('no_gclient_branch', False) 298 no_gclient_branch = factory_properties.get('no_gclient_branch', False)
299 no_gclient_revision = factory_properties.get('no_gclient_revision', False) 299 no_gclient_revision = factory_properties.get('no_gclient_revision', False)
300 300
301 gclient_transitive = factory_properties.get('gclient_transitive', False) 301 gclient_transitive = factory_properties.get('gclient_transitive', False)
302 primary_repo = factory_properties.get('primary_repo', '') 302 primary_repo = factory_properties.get('primary_repo', '')
303 gclient_jobs = factory_properties.get('gclient_jobs') 303 gclient_jobs = factory_properties.get('gclient_jobs')
304 blink_config = factory_properties.get('blink_config')
304 305
305 # Add the update step. 306 # Add the update step.
306 factory_cmd_obj.AddUpdateStep( 307 factory_cmd_obj.AddUpdateStep(
307 gclient_spec, 308 gclient_spec,
308 env=env, 309 env=env,
309 timeout=timeout, 310 timeout=timeout,
310 sudo_for_remove=sudo_for_remove, 311 sudo_for_remove=sudo_for_remove,
311 gclient_deps=gclient_deps, 312 gclient_deps=gclient_deps,
312 gclient_nohooks=True, 313 gclient_nohooks=True,
313 no_gclient_branch=no_gclient_branch, 314 no_gclient_branch=no_gclient_branch,
314 no_gclient_revision=no_gclient_revision, 315 no_gclient_revision=no_gclient_revision,
315 gclient_transitive=gclient_transitive, 316 gclient_transitive=gclient_transitive,
316 primary_repo=primary_repo, 317 primary_repo=primary_repo,
317 gclient_jobs=gclient_jobs) 318 gclient_jobs=gclient_jobs,
319 blink_config=blink_config)
318 320
319 if slave_type in ('AnnotatedTrybot', 'CrosTrybot', 'Trybot', 'Bisect'): 321 if slave_type in ('AnnotatedTrybot', 'CrosTrybot', 'Trybot', 'Bisect'):
320 factory_cmd_obj.AddApplyIssueStep( 322 factory_cmd_obj.AddApplyIssueStep(
321 timeout=timeout, 323 timeout=timeout,
322 server=config.Master.TryServer.code_review_site) 324 server=config.Master.TryServer.code_review_site)
323 325
324 if not self._nohooks_on_update: 326 if not self._nohooks_on_update:
325 factory_cmd_obj.AddRunHooksStep(env=env, timeout=timeout) 327 factory_cmd_obj.AddRunHooksStep(env=env, timeout=timeout)
OLDNEW
« no previous file with comments | « scripts/master/factory/commands.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698