Rework how bots get the version of Blink.

scripts/master/factory/chromium_factory.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Utility class to build the chromium master BuildFactory's.
 
 Based on gclient_factory.py and adds chromium-specific steps."""
 
 import os
 import re
@@ skipping 25 matching lines @@
 
   DEFAULT_TARGET_PLATFORM = config.Master.default_platform
 
   MEMORY_TOOLS_GYP_DEFINES = 'build_for_tool=memcheck'
 
   # gclient custom vars
   CUSTOM_VARS_GOOGLECODE_URL = ('googlecode_url', config.Master.googlecode_url)
   CUSTOM_VARS_SOURCEFORGE_URL = ('sourceforge_url',
                                  config.Master.sourceforge_url)
   CUSTOM_VARS_WEBKIT_MIRROR = ('webkit_trunk', config.Master.webkit_trunk_url)
-  # $$WK_REV$$ below will be substituted with the revision that triggered the
-  # build in chromium_step.py@GClient.startVC. Use this only with builds
-  # triggered by a webkit poller.
-  CUSTOM_VARS_WEBKIT_LATEST = [('webkit_revision', '$$WK_REV$$')]
   CUSTOM_VARS_NACL_TRUNK_URL = ('nacl_trunk', config.Master.nacl_trunk_url)
   # safe sync urls
   SAFESYNC_URL_CHROMIUM = 'http://chromium-status.appspot.com/lkgr'
 
   # gclient additional custom deps
   CUSTOM_DEPS_V8_LATEST = ('src/v8',
     'http://v8.googlecode.com/svn/branches/bleeding_edge')
   CUSTOM_DEPS_WEBRTC_TRUNK = ('src/third_party/webrtc',
     config.Master.webrtc_url + '/trunk/webrtc')
   CUSTOM_DEPS_WEBRTC_STABLE = ('src/third_party/webrtc',
@@ skipping 822 matching lines @@
         'msvs_error_on_missing_sources=' not in gyp_generator_flags):
       gclient_env['GYP_GENERATOR_FLAGS'] = (
           gyp_generator_flags + ' msvs_error_on_missing_sources=1')
 
   def ChromiumFactory(self, target='Release', clobber=False, tests=None,
                       mode=None, slave_type='BuilderTester',
                       options=None, compile_timeout=1200, build_url=None,
                       project=None, factory_properties=None, gclient_deps=None,
                       enable_swarm_tests=False):
     factory_properties = (factory_properties or {}).copy()
+
+    # Default to the configuration of Blink appropriate for Chromium patches.
+    factory_properties.setdefault('blink_config', 'chromium')
+    if factory_properties['blink_config'] == 'blink':
+      # This will let builders embed their webkit revision in their output
+      # filename and will let testers look for zip files containing a webkit
+      # revision in their filename. For this to work correctly, the testers
+      # need to be on a Triggerable that's activated by their builder.
+      factory_properties.setdefault('webkit_dir', 'third_party/WebKit/Source')
+
     factory_properties['gclient_env'] = \
         factory_properties.get('gclient_env', {}).copy()
     # Defaults gyp to VS2010.
     if self._target_platform == 'win32':
       factory_properties['gclient_env'].setdefault('GYP_MSVS_VERSION', '2010')
     tests = tests or []
 
-    # This permits simpler WebKit specific try jobs.
-    if slave_type == 'Trybot':
-      self._solutions[0].custom_vars_list.append(
-          ('webkit_revision', '$$WK_TRY_REV$$'))
-
     if factory_properties.get('needs_valgrind'):
       self._solutions[0].custom_deps_list = [self.CUSTOM_DEPS_VALGRIND]
     elif factory_properties.get('needs_tsan_win'):
       self._solutions[0].custom_deps_list = [self.CUSTOM_DEPS_TSAN_WIN]
     elif factory_properties.get('needs_drmemory'):
       if 'drmemory.DEPS' not in [s.name for s in self._solutions]:
         self._solutions.append(gclient_factory.GClientSolution(
             config.Master.trunk_url +
             '/deps/third_party/drmemory/drmemory.DEPS',
             'drmemory.DEPS'))
@@ skipping 217 matching lines @@
       v for v in self._solutions[0].custom_vars_list if v[0] != 'nacl_trunk'
     ]
     self._solutions[0].custom_vars_list.extend(self.CUSTOM_VARS_NACL_LATEST)
     self._solutions[0].safesync_url = self.SAFESYNC_URL_CHROMIUM
     if factory_properties.get('needs_nacl_valgrind'):
       self._solutions[0].custom_deps_list.append(self.CUSTOM_DEPS_NACL_VALGRIND)
     return self.ChromiumFactory(target, clobber, tests, mode, slave_type,
                                 options, compile_timeout, build_url, project,
                                 factory_properties)
 
-  def _InitWebkitLatestFactorySettings(self, factory_properties):
-    self._solutions[0].custom_vars_list.extend(self.CUSTOM_VARS_WEBKIT_LATEST)
-
-    # This will let builders embed their webkit revision in their output
-    # filename and will let testers look for zip files containing a webkit
-    # revision in their filename. For this to work correctly, the testers
-    # need to be on a Triggerable that's activated by their builder.
-    factory_properties.setdefault('webkit_dir', 'third_party/WebKit/Source')
-
-  def ChromiumWebkitLatestAnnotationFactory(self, annotation_script,
-                                            branch='master', target='Release',
-                                            slave_type='AnnotatedBuilderTester',
-                                            clobber=False, compile_timeout=6000,
-                                            project=None,
-                                            factory_properties=None,
-                                            tests=None):
-    factory_properties = factory_properties or {}
-    self._InitWebkitLatestFactorySettings(factory_properties)
-
-    return self.ChromiumAnnotationFactory(
-        annotation_script=annotation_script, branch=branch, target=target,
-        slave_type=slave_type, clobber=clobber, compile_timeout=compile_timeout,
-        project=project, factory_properties=factory_properties, tests=tests)
-
-  def ChromiumWebkitLatestFactory(self, target='Release', clobber=False,
-                                  tests=None, mode=None,
-                                  slave_type='BuilderTester', options=None,
-                                  compile_timeout=1200, build_url=None,
-                                  project=None, factory_properties=None):
-    factory_properties = factory_properties or {}
-    self._InitWebkitLatestFactorySettings(factory_properties)
-
-    return self.ChromiumFactory(target, clobber, tests, mode, slave_type,
-                                options, compile_timeout, build_url, project,
-                                factory_properties)
-
-  def ChromiumOSWebkitLatestFactory(self, target='Release', clobber=False,
-                                    tests=None, mode=None,
-                                    slave_type='BuilderTester', options=None,
-                                    compile_timeout=1200, build_url=None,
-                                    project=None, factory_properties=None):
-    # Make sure the solution is not already there.
-    if 'cros_deps' not in [s.name for s in self._solutions]:
-      self._solutions.append(gclient_factory.GClientSolution(
-          config.Master.trunk_url + '/src/tools/cros.DEPS', name='cros_deps'))
-
-    return self.ChromiumWebkitLatestFactory(target, clobber, tests, mode,
-                                            slave_type, options,
-                                            compile_timeout, build_url,
-                                            project, factory_properties)
-
   def ChromiumGYPLatestFactory(self, target='Debug', clobber=False, tests=None,
                                mode=None, slave_type='BuilderTester',
                                options=None, compile_timeout=1200,
                                build_url=None, project=None,
                                factory_properties=None, gyp_format=None):
 
     if tests is None:
       tests = ['unit']
 
     if gyp_format:
@@ skipping 158 matching lines @@
                                                build_dir=web_build_dir)
       chromium_cmd_obj.AddChromebotServer(factory_properties)
       chromium_cmd_obj.AddReliabilityTests(client_os)
     elif slave_type == 'ChromebotClient':
       chromium_cmd_obj.AddGetBuildForChromebot(client_os,
                                                extract=True,
                                                build_url=build_url)
       chromium_cmd_obj.AddChromebotClient(factory_properties)
 
     return factory