Deeper histogram for SQLITE_IOERR.

Deeper histogram for SQLITE_IOERR.

Sqlite.Error records the basic SQLite error codes.  Most of the
extended codes are under SQLITE_IOERR, add a new histogram to record
those.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197147

[Scott Hess - ex-Googler, 2013-04-25 20:08:09]

Since you were on the email thread ...

WRT the TODO, doing that would potentially allow all of the Error histograms to
be updated.  But I don't want to commit us to some screwed-up mapping long term.

[erikwright (departed), 2013-04-26 14:45:07]

LGTM. I guess there will also be an addition to histograms.xml.

[Scott Hess - ex-Googler, 2013-04-26 14:52:56]

On 2013/04/26 14:45:07, erikwright wrote:
> LGTM. I guess there will also be an addition to histograms.xml.

Oops - good point!  I had forgotten that histograms.xml was moving into the main
repo.  I'll circle back with that change once I'm at the right desk.

[Scott Hess - ex-Googler, 2013-04-26 17:16:15]

On 2013/04/26 14:52:56, shess wrote:
> On 2013/04/26 14:45:07, erikwright wrote:
> > LGTM. I guess there will also be an addition to histograms.xml.
> 
> Oops - good point!  I had forgotten that histograms.xml was moving into the
main
> repo.  I'll circle back with that change once I'm at the right desk.

jar@ for OWNERS on histograms.xml.  This is a new histogram.

[erikwright (departed), 2013-04-26 17:27:40]

Still LGTM.

https://codereview.chromium.org/14439007/diff/3002/tools/metrics/histograms/h...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/14439007/diff/3002/tools/metrics/histograms/h...
tools/metrics/histograms/histograms.xml:5752: <histogram
name="Sqlite.Error.IOERR" enum="SqliteIOERRCode">
I assume that, other than this one, the rest are moved verbatim?

https://codereview.chromium.org/14439007/diff/3002/tools/metrics/histograms/h...
tools/metrics/histograms/histograms.xml:9113: <summary>Error codes returned by
SQLite - see sqlite.h</summary>
I assume this enum is moved verbatim?

[Scott Hess - ex-Googler, 2013-04-26 17:50:53]

Sorry about that, rebaselined.

https://codereview.chromium.org/14439007/diff/3002/tools/metrics/histograms/h...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/14439007/diff/3002/tools/metrics/histograms/h...
tools/metrics/histograms/histograms.xml:5752: <histogram
name="Sqlite.Error.IOERR" enum="SqliteIOERRCode">
On 2013/04/26 17:27:40, erikwright wrote:
> I assume that, other than this one, the rest are moved verbatim?

Apologies - I think I made a baselining mistake, all of the others should have
already been checked in.  Let me try again.

[jar (doing other things), 2013-04-26 22:06:28]

histograms.xml in patch set 3 lgtm

[commit-bot: I haz the power, 2013-04-26 22:29:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shess@chromium.org/14439007/9001

[commit-bot: I haz the power, 2013-04-26 22:40:56]

Retried try job too often on linux_aura for step(s) aura_unittests,
browser_tests, compositor_unittests, content_browsertests, content_unittests,
interactive_ui_tests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-04-29 19:39:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shess@chromium.org/14439007/9001

[commit-bot: I haz the power, 2013-04-29 21:21:08]

Change committed as 197147

[jar (doing other things), 2013-04-30 00:45:28]

It appears that the last "rebaseline" you did produced a merge that was not in
alphabetical order (take a look at the enums in the checked in code... and
you'll see T comes before S).  

I don't know why the presubmit check didn't stop you.... but the pushes are
broken... so I'll do a quick revert.

[Scott Hess - ex-Googler, 2013-04-30 02:22:24]

On 2013/04/30 00:45:28, jar wrote:
> It appears that the last "rebaseline" you did produced a merge that was not in
> alphabetical order (take a look at the enums in the checked in code... and
> you'll see T comes before S).  
> 
> I don't know why the presubmit check didn't stop you.... but the pushes are
> broken... so I'll do a quick revert.

AFAICT from this CL, it's in the right order.  So I'm pointing my finger at the
commit queue process, maybe?