Issue 14436005: [Android] Set build.is.packaging.debug correctly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14436005: [Android] Set build.is.packaging.debug correctly (Closed)

Created:
7 years, 8 months ago by cjhopman

Modified:
7 years, 8 months ago

Reviewers:
shashi, Yaron

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, ilevy+watch_chromium.org, frankf+watch_chromium.org, digit1

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Set build.is.packaging.debug correctly The string "build.target" was being used rather than the variable-expanded "${build.target}". NOTRY=true BUG=234546 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196104

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	build/android/ant/apk-package.xml	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	build/android/ant/apk-package-resources.xml	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

shashi

LGTM, make sure to try attaching gdb to apk after this change.

7 years, 8 months ago (2013-04-23 18:08:48 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/14436005/1

7 years, 8 months ago (2013-04-23 20:26:58 UTC) #5

Message was sent while issue was closed.

Change committed as 196104

Expand Messages | Collapse Messages