Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1260)

Issue 14432003: Normalize output path to cp.py (Closed)

Created:
7 years, 7 months ago by Yaron
Modified:
7 years, 7 months ago
Reviewers:
cjhopman
CC:
chromium-reviews, Sheridan Rawlins
Visibility:
Public.

Description

Normalize output path to cp.py The js unit test targets have subtle dependencies on sources. Specifically, a rule pulls in js files and generates/runs js tests for them. This can be an issue with a relative path when the commands are run in parallel because a relative path may not exist. In this case, the rule for cr.js which is in ui depends on chrome. An easy way to repro this failure is: $ ninja -C out/Debug unit_tests $ rm -rf out/Debug/test_data $ ninja -C out/Debug test_data/chrome/../ui/webui/resources/js/cr.js Ninja is fine because it normalizes the path early enough whereas in python we relied on the system to compute the path but out/Debug/test_data/chrome may not exist BUG=235731 Hat-tip to cjhopman for help debugging. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197224

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/cp.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Yaron
7 years, 7 months ago (2013-04-29 22:38:28 UTC) #1
cjhopman
lgtm
7 years, 7 months ago (2013-04-29 22:52:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/14432003/1
7 years, 7 months ago (2013-04-29 22:55:32 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-04-30 01:57:12 UTC) #4
Message was sent while issue was closed.
Change committed as 197224

Powered by Google App Engine
This is Rietveld 408576698