Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Side by Side Diff: media/audio/android/audio_manager_android.cc

Issue 14430003: Using native sampling rate and optimal buffer size for audio on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/audio/android/audio_manager_android.h" 5 #include "media/audio/android/audio_manager_android.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "jni/AudioManagerAndroid_jni.h" 8 #include "jni/AudioManagerAndroid_jni.h"
9 #include "media/audio/android/opensles_input.h" 9 #include "media/audio/android/opensles_input.h"
10 #include "media/audio/android/opensles_output.h" 10 #include "media/audio/android/opensles_output.h"
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 49
50 void AudioManagerAndroid::GetAudioInputDeviceNames( 50 void AudioManagerAndroid::GetAudioInputDeviceNames(
51 media::AudioDeviceNames* device_names) { 51 media::AudioDeviceNames* device_names) {
52 DCHECK(device_names->empty()); 52 DCHECK(device_names->empty());
53 device_names->push_front( 53 device_names->push_front(
54 media::AudioDeviceName(kDefaultDeviceName, kDefaultDeviceId)); 54 media::AudioDeviceName(kDefaultDeviceName, kDefaultDeviceId));
55 } 55 }
56 56
57 AudioParameters AudioManagerAndroid::GetInputStreamParameters( 57 AudioParameters AudioManagerAndroid::GetInputStreamParameters(
58 const std::string& device_id) { 58 const std::string& device_id) {
59 // TODO(xians): figure out the right input sample rate and buffer size to
60 // achieve the best audio performance for Android devices.
61 // TODO(xians): query the native channel layout for the specific device.
62 static const int kDefaultSampleRate = 16000;
63 static const int kDefaultBufferSize = 1024; 59 static const int kDefaultBufferSize = 1024;
60 int size = GetMinInputBufferSize(GetNativeOutputSampleRate(), 2);
64 return AudioParameters( 61 return AudioParameters(
65 AudioParameters::AUDIO_PCM_LOW_LATENCY, CHANNEL_LAYOUT_STEREO, 62 AudioParameters::AUDIO_PCM_LOW_LATENCY, CHANNEL_LAYOUT_STEREO,
66 kDefaultSampleRate, 16, kDefaultBufferSize); 63 GetNativeOutputSampleRate(), 16, size <= 0 ? kDefaultBufferSize : size);
67 } 64 }
68 65
69 AudioOutputStream* AudioManagerAndroid::MakeAudioOutputStream( 66 AudioOutputStream* AudioManagerAndroid::MakeAudioOutputStream(
70 const AudioParameters& params) { 67 const AudioParameters& params) {
71 AudioOutputStream* stream = 68 AudioOutputStream* stream =
72 AudioManagerBase::MakeAudioOutputStream(params); 69 AudioManagerBase::MakeAudioOutputStream(params);
73 if (stream && output_stream_count() == 1) 70 if (stream && output_stream_count() == 1)
74 RegisterHeadsetReceiver(); 71 RegisterHeadsetReceiver();
75 return stream; 72 return stream;
76 } 73 }
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 DCHECK_EQ(AudioParameters::AUDIO_PCM_LINEAR, params.format()); 110 DCHECK_EQ(AudioParameters::AUDIO_PCM_LINEAR, params.format());
114 return new OpenSLESInputStream(this, params); 111 return new OpenSLESInputStream(this, params);
115 } 112 }
116 113
117 AudioInputStream* AudioManagerAndroid::MakeLowLatencyInputStream( 114 AudioInputStream* AudioManagerAndroid::MakeLowLatencyInputStream(
118 const AudioParameters& params, const std::string& device_id) { 115 const AudioParameters& params, const std::string& device_id) {
119 DCHECK_EQ(AudioParameters::AUDIO_PCM_LOW_LATENCY, params.format()); 116 DCHECK_EQ(AudioParameters::AUDIO_PCM_LOW_LATENCY, params.format());
120 return new OpenSLESInputStream(this, params); 117 return new OpenSLESInputStream(this, params);
121 } 118 }
122 119
120 int AudioManagerAndroid::GetAudioOptimalOutputFrameSize(int sample_rate) {
121 return IsAudioLowLatencySupported() ? GetAudioLowLatencyFrameSize() * 4 :
122 GetMinOutputBufferSize(sample_rate, 1) / 2;
123 }
124
123 AudioParameters AudioManagerAndroid::GetPreferredOutputStreamParameters( 125 AudioParameters AudioManagerAndroid::GetPreferredOutputStreamParameters(
124 const AudioParameters& input_params) { 126 const AudioParameters& input_params) {
125 // TODO(xians): figure out the right output sample rate and buffer size to
126 // achieve the best audio performance for Android devices.
127 static const int kDefaultSampleRate = 44100;
128 static const int kDefaultBufferSize = 2048; 127 static const int kDefaultBufferSize = 2048;
129
130 ChannelLayout channel_layout = CHANNEL_LAYOUT_STEREO; 128 ChannelLayout channel_layout = CHANNEL_LAYOUT_STEREO;
131 int sample_rate = kDefaultSampleRate; 129 int sample_rate = GetNativeOutputSampleRate();
132 int buffer_size = kDefaultBufferSize; 130 int buffer_size = GetAudioOptimalOutputFrameSize(sample_rate);
133 int bits_per_sample = 16; 131 int bits_per_sample = 16;
134 int input_channels = 0; 132 int input_channels = 0;
135 if (input_params.IsValid()) { 133 if (input_params.IsValid()) {
136 // Use the client's input parameters if they are valid. 134 // Use the client's input parameters if they are valid.
137 sample_rate = input_params.sample_rate(); 135 sample_rate = input_params.sample_rate();
138 bits_per_sample = input_params.bits_per_sample(); 136 bits_per_sample = input_params.bits_per_sample();
139 channel_layout = input_params.channel_layout(); 137 channel_layout = input_params.channel_layout();
140 input_channels = input_params.input_channels(); 138 input_channels = input_params.input_channels();
141 139 buffer_size = buffer_size <= 0 ? kDefaultBufferSize : buffer_size;
142 // TODO(leozwang): Android defines the minimal buffer size requirment
143 // we should follow it. From Android 4.1, a new audio low latency api
144 // set was introduced and is under development, we want to take advantage
145 // of it.
146 buffer_size = std::min(buffer_size, input_params.frames_per_buffer());
147 } 140 }
148 141
149 int user_buffer_size = GetUserBufferSize(); 142 int user_buffer_size = GetUserBufferSize();
150 if (user_buffer_size) 143 if (user_buffer_size)
151 buffer_size = user_buffer_size; 144 buffer_size = user_buffer_size;
152 145
153 return AudioParameters( 146 return AudioParameters(
154 AudioParameters::AUDIO_PCM_LOW_LATENCY, channel_layout, input_channels, 147 AudioParameters::AUDIO_PCM_LOW_LATENCY, channel_layout, input_channels,
155 sample_rate, bits_per_sample, buffer_size); 148 sample_rate, bits_per_sample, buffer_size);
156 } 149 }
(...skipping 14 matching lines...) Expand all
171 base::android::AttachCurrentThread(), 164 base::android::AttachCurrentThread(),
172 j_audio_manager_.obj()); 165 j_audio_manager_.obj());
173 } 166 }
174 167
175 void AudioManagerAndroid::UnregisterHeadsetReceiver() { 168 void AudioManagerAndroid::UnregisterHeadsetReceiver() {
176 Java_AudioManagerAndroid_unregisterHeadsetReceiver( 169 Java_AudioManagerAndroid_unregisterHeadsetReceiver(
177 base::android::AttachCurrentThread(), 170 base::android::AttachCurrentThread(),
178 j_audio_manager_.obj()); 171 j_audio_manager_.obj());
179 } 172 }
180 173
174 int AudioManagerAndroid::GetNativeOutputSampleRate() {
175 return Java_AudioManagerAndroid_getNativeOutputSampleRate(
176 base::android::AttachCurrentThread(),
177 j_audio_manager_.obj());
178 }
179
180 int AudioManagerAndroid::GetMinInputBufferSize(int rate, int channels) {
181 return Java_AudioManagerAndroid_getMinInputBufSize(
182 base::android::AttachCurrentThread(),
183 rate, channels);
184 }
185
186 int AudioManagerAndroid::GetMinOutputBufferSize(int rate, int channels) {
187 return Java_AudioManagerAndroid_getMinOutputBufSize(
188 base::android::AttachCurrentThread(),
189 rate, channels);
190 }
191
192 bool AudioManagerAndroid::IsAudioLowLatencySupported() {
193 return Java_AudioManagerAndroid_isAudioLowLatencySupported(
194 base::android::AttachCurrentThread(),
195 j_audio_manager_.obj());
196 }
197
198 int AudioManagerAndroid::GetAudioLowLatencyFrameSize() {
199 return Java_AudioManagerAndroid_getAudioLowLatencyFrameSize(
200 base::android::AttachCurrentThread(),
201 j_audio_manager_.obj());
202 }
203
181 } // namespace media 204 } // namespace media
OLDNEW
« no previous file with comments | « media/audio/android/audio_manager_android.h ('k') | media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698