src/x64/regexp-macro-assembler-x64.h - Issue 14429003: Refactor ExternalReference::isolate_address() to not rely on Isolate::Current().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/regexp-macro-assembler-x64.h

Issue 14429003: Refactor ExternalReference::isolate_address() to not rely on Isolate::Current(). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed comments Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/regexp-macro-assembler-x64.h

diff --git a/src/x64/regexp-macro-assembler-x64.h b/src/x64/regexp-macro-assembler-x64.h

index a082cf2df37710662feb3522d35d43da6ce3f28f..296c866019adf2e5d3b5044c3ba6b6402fb84cb7 100644

--- a/src/x64/regexp-macro-assembler-x64.h

+++ b/src/x64/regexp-macro-assembler-x64.h

@@ -272,6 +272,8 @@ class RegExpMacroAssemblerX64: public NativeRegExpMacroAssembler {

// Increments the stack pointer (rcx) by a word size.

inline void Drop();

+ Isolate* isolate() const { return masm_.isolate(); }

MacroAssembler masm_;

MacroAssembler::NoRootArrayScope no_root_array_scope_;

« no previous file with comments | « src/x64/macro-assembler-x64.cc ('k') | src/x64/regexp-macro-assembler-x64.cc » ('j') | no next file with comments »